Stream: git-wasmtime

Topic: wasmtime / PR #2341 Updates comments on Int to Float conv...

Wasmtime GitHub notifications bot (Oct 31 2020 at 00:25):

jlb6740 opened PR #2341 from update_comments_on_int_float_conversion to main:

Int to float for unsigned ints has merged, but there were
some comments on a different PR for the same pull request that
are addressed in this PR

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 31 2020 at 00:25):

jlb6740 requested cfallin for a review on PR #2341.

Wasmtime GitHub notifications bot (Oct 31 2020 at 00:25):

jlb6740 requested cfallin and abrown for a review on PR #2341.

Wasmtime GitHub notifications bot (Oct 31 2020 at 01:41):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Oct 31 2020 at 01:41):

cfallin merged PR #2341.

Last updated: Nov 22 2024 at 17:03 UTC