Stream: git-wasmtime

Topic: wasmtime / PR #2335 Add missing `SourceLoc` to newly-emit...


view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 20:46):

abrown opened PR #2335 from fix-ci to main:

The changes in https://github.com/bytecodealliance/wasmtime/pull/2278 added SourceLocs to several x64 Inst variants; between when that PR was last run in CI and when it was merged, new instructions were added that require this new parameter. This change adds the parameter in order to fix CI.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 20:46):

abrown requested cfallin and jlb6740 for a review on PR #2335.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 20:46):

abrown requested cfallin and jlb6740 for a review on PR #2335.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 20:47):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 20:57):

abrown updated PR #2335 from fix-ci to main:

The changes in https://github.com/bytecodealliance/wasmtime/pull/2278 added SourceLocs to several x64 Inst variants; between when that PR was last run in CI and when it was merged, new instructions were added that require this new parameter. This change adds the parameter in order to fix CI.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 21:21):

jlb6740 closed without merge PR #2335.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 21:21):

jlb6740 reopened PR #2335 from fix-ci to main:

The changes in https://github.com/bytecodealliance/wasmtime/pull/2278 added SourceLocs to several x64 Inst variants; between when that PR was last run in CI and when it was merged, new instructions were added that require this new parameter. This change adds the parameter in order to fix CI.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 21:21):

jlb6740 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 28 2020 at 21:33):

abrown merged PR #2335.


Last updated: Dec 23 2024 at 12:05 UTC