Wasmtime GitHub notifications bot (Oct 27 2020 at 03:43): Wasmtime GitHub notifications bot (Oct 27 2020 at 03:43):alexcrichton opened PR #2326 from rm-windows-case to main:
Added in c4e10227de1358d009cf8fb7df55a1c9dfb675d5 I think the original
reason (which I'm not entirely knowledgeable of) may no longer be
applicable? In any case this is a significant difference on Windows from
other platforms because it makes loads/stores of wasm code have manual
checks instead of relying on the guard page, causing runtime and
compile-time slowdowns on Windows-only.I originally rediscovered this when investigating #2318 and saw that
both the compile time of the module in question and trap information
tables were much larger than they were on Linux. Removing this
Windows-specific configuration fixed the discrepancies and afterwards
Linux and Windows were basically the same.
Wasmtime GitHub notifications bot (Oct 27 2020 at 04:19):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Oct 28 2020 at 23:49):sunfishcode merged PR #2326.
Last updated: Dec 23 2024 at 12:05 UTC