wasmtime / PR #2313 machinst aarch64: New backend unwind · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #2313 machinst aarch64: New backend unwind

Wasmtime GitHub notifications bot (Oct 23 2020 at 20:27):

yurydelendik opened PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Oct 23 2020 at 22:03):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 18:52):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 18:52):

yurydelendik edited PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 18:54):

yurydelendik edited PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:06):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:30):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 20:59):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 21:02):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 04 2020 at 21:28):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[ ] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 13:33):

yurydelendik edited PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 14:24):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[ ] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 15:22):

yurydelendik edited PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[x] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 15:22):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[x] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 16:53):

yurydelendik has marked PR #2313 as ready for review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 19:52):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 19:52):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 19:52):

cfallin created PR Review Comment:

winx64 left over from copy+paste?

Wasmtime GitHub notifications bot (Nov 05 2020 at 22:26):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[x] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:11):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[x] Add unit tests

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:13):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:13):

yurydelendik created PR Review Comment:

yes, but it is also a TODO to support windows fastcall abi

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:20):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:20):

cfallin created PR Review Comment:

Remove commented-out debugging print?

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:20):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:20):

cfallin created PR Review Comment:

OK, gotcha, maybe something like TODO: support Windows unwind info on AArch64 then?

Wasmtime GitHub notifications bot (Nov 05 2020 at 23:33):

yurydelendik updated PR #2313 from new-backend-unwind-a64 to main:

Implements UnwindInfoGenerator for Aarch64. Mostly it is a continuation of #2266. The "traps::*"-test for SystemV can be enabled.

[x] Refactor common code with x64

[x] Add unit tests

Wasmtime GitHub notifications bot (Nov 06 2020 at 14:02):

yurydelendik merged PR #2313.

Last updated: Oct 23 2024 at 20:03 UTC