Stream: git-wasmtime

Topic: wasmtime / PR #2312 CL/aarch64: implement the wasm SIMD p...

Wasmtime GitHub notifications bot (Oct 23 2020 at 09:43):

julian-seward1 opened PR #2312 from arm64-simd-pminmax-round to main:

…structions

This patch implements, for aarch64, the following wasm SIMD extensions

Floating-point rounding instructions
https://github.com/WebAssembly/simd/pull/232

Pseudo-Minimum and Pseudo-Maximum instructions
https://github.com/WebAssembly/simd/pull/122

The changes are straightforward:

• build.rs: the relevant tests have been enabled

• cranelift/codegen/meta/src/shared/instructions.rs: new CLIF instructions
  fmin_pseudo and fmax_pseudo. The wasm rounding instructions do not need
  any new CLIF instructions.

• cranelift/wasm/src/code_translator.rs: translation into CLIF; this is
  pretty much the same as any other unary or binary vector instruction (for
  the rounding and the pmin/max respectively)

• cranelift/codegen/src/isa/aarch64/lower_inst.rs:

  • fmin_pseudo and fmax_pseudo are converted into a two instruction
    sequence, fcmpgt followed by bsl

  • the CLIF rounding instructions are converted to a suitable vector
    frint{n,z,p,m} instruction.

• cranelift/codegen/src/isa/aarch64/inst/mod.rs: minor extension of pub enum VecMisc2 to handle the rounding operations. And corresponding emit
  cases.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 23 2020 at 13:44):

julian-seward1 requested yurydelendik for a review on PR #2312.

Wasmtime GitHub notifications bot (Oct 23 2020 at 15:49):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Oct 23 2020 at 15:49):

yurydelendik created PR Review Comment:

Based on the referred PR and tests cases at simd_XX_pmin_pmax.wast's , the NaN behavior is different. I recommend to copy pmin(a, b) := b < a ? b : a definition language here is extract NaN propagation from it.

Wasmtime GitHub notifications bot (Oct 23 2020 at 15:50):

yurydelendik edited PR Review Comment.

Wasmtime GitHub notifications bot (Oct 23 2020 at 16:13):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Oct 23 2020 at 17:17):

julian-seward1 updated PR #2312 from arm64-simd-pminmax-round to main:

…structions

This patch implements, for aarch64, the following wasm SIMD extensions

Floating-point rounding instructions
https://github.com/WebAssembly/simd/pull/232

Pseudo-Minimum and Pseudo-Maximum instructions
https://github.com/WebAssembly/simd/pull/122

The changes are straightforward:

• build.rs: the relevant tests have been enabled

• cranelift/codegen/meta/src/shared/instructions.rs: new CLIF instructions
  fmin_pseudo and fmax_pseudo. The wasm rounding instructions do not need
  any new CLIF instructions.

• cranelift/wasm/src/code_translator.rs: translation into CLIF; this is
  pretty much the same as any other unary or binary vector instruction (for
  the rounding and the pmin/max respectively)

• cranelift/codegen/src/isa/aarch64/lower_inst.rs:

  • fmin_pseudo and fmax_pseudo are converted into a two instruction
    sequence, fcmpgt followed by bsl

  • the CLIF rounding instructions are converted to a suitable vector
    frint{n,z,p,m} instruction.

• cranelift/codegen/src/isa/aarch64/inst/mod.rs: minor extension of pub enum VecMisc2 to handle the rounding operations. And corresponding emit
  cases.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 23 2020 at 17:40):

julian-seward1 updated PR #2312 from arm64-simd-pminmax-round to main:

…structions

This patch implements, for aarch64, the following wasm SIMD extensions

Floating-point rounding instructions
https://github.com/WebAssembly/simd/pull/232

Pseudo-Minimum and Pseudo-Maximum instructions
https://github.com/WebAssembly/simd/pull/122

The changes are straightforward:

• build.rs: the relevant tests have been enabled

• cranelift/codegen/meta/src/shared/instructions.rs: new CLIF instructions
  fmin_pseudo and fmax_pseudo. The wasm rounding instructions do not need
  any new CLIF instructions.

• cranelift/wasm/src/code_translator.rs: translation into CLIF; this is
  pretty much the same as any other unary or binary vector instruction (for
  the rounding and the pmin/max respectively)

• cranelift/codegen/src/isa/aarch64/lower_inst.rs:

  • fmin_pseudo and fmax_pseudo are converted into a two instruction
    sequence, fcmpgt followed by bsl

  • the CLIF rounding instructions are converted to a suitable vector
    frint{n,z,p,m} instruction.

• cranelift/codegen/src/isa/aarch64/inst/mod.rs: minor extension of pub enum VecMisc2 to handle the rounding operations. And corresponding emit
  cases.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 24 2020 at 08:57):

julian-seward1 updated PR #2312 from arm64-simd-pminmax-round to main:

…structions

This patch implements, for aarch64, the following wasm SIMD extensions

Floating-point rounding instructions
https://github.com/WebAssembly/simd/pull/232

Pseudo-Minimum and Pseudo-Maximum instructions
https://github.com/WebAssembly/simd/pull/122

The changes are straightforward:

• build.rs: the relevant tests have been enabled

• cranelift/codegen/meta/src/shared/instructions.rs: new CLIF instructions
  fmin_pseudo and fmax_pseudo. The wasm rounding instructions do not need
  any new CLIF instructions.

• cranelift/wasm/src/code_translator.rs: translation into CLIF; this is
  pretty much the same as any other unary or binary vector instruction (for
  the rounding and the pmin/max respectively)

• cranelift/codegen/src/isa/aarch64/lower_inst.rs:

  • fmin_pseudo and fmax_pseudo are converted into a two instruction
    sequence, fcmpgt followed by bsl

  • the CLIF rounding instructions are converted to a suitable vector
    frint{n,z,p,m} instruction.

• cranelift/codegen/src/isa/aarch64/inst/mod.rs: minor extension of pub enum VecMisc2 to handle the rounding operations. And corresponding emit
  cases.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 26 2020 at 08:57):

julian-seward1 updated PR #2312 from arm64-simd-pminmax-round to main:

…structions

This patch implements, for aarch64, the following wasm SIMD extensions

Floating-point rounding instructions
https://github.com/WebAssembly/simd/pull/232

Pseudo-Minimum and Pseudo-Maximum instructions
https://github.com/WebAssembly/simd/pull/122

The changes are straightforward:

• build.rs: the relevant tests have been enabled

• cranelift/codegen/meta/src/shared/instructions.rs: new CLIF instructions
  fmin_pseudo and fmax_pseudo. The wasm rounding instructions do not need
  any new CLIF instructions.

• cranelift/wasm/src/code_translator.rs: translation into CLIF; this is
  pretty much the same as any other unary or binary vector instruction (for
  the rounding and the pmin/max respectively)

• cranelift/codegen/src/isa/aarch64/lower_inst.rs:

  • fmin_pseudo and fmax_pseudo are converted into a two instruction
    sequence, fcmpgt followed by bsl

  • the CLIF rounding instructions are converted to a suitable vector
    frint{n,z,p,m} instruction.

• cranelift/codegen/src/isa/aarch64/inst/mod.rs: minor extension of pub enum VecMisc2 to handle the rounding operations. And corresponding emit
  cases.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 26 2020 at 09:37):

julian-seward1 merged PR #2312.

Last updated: Oct 23 2024 at 20:03 UTC