Stream: git-wasmtime

Topic: wasmtime / PR #2311 CI: fix rebuilding peepmatic peephole...

Wasmtime GitHub notifications bot (Oct 22 2020 at 17:13):

fitzgen opened PR #2311 from fix-peepmatic-ci to main:

The test that triggers the rebuild of the peephole optimizers is in the cranelift-codegen crate, not the umbrella cranelift crate. This was previously successfully running zero tests, and then successfully reporting no git diff because no peephole optimizers were ever rebuilt.

This change fixes it so that we run the correct test that triggers the rebuilding of the peephole optimizers.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 22 2020 at 17:13):

fitzgen requested alexcrichton for a review on PR #2311.

Wasmtime GitHub notifications bot (Oct 22 2020 at 17:39):

alexcrichton merged PR #2311.

Last updated: Oct 23 2024 at 20:03 UTC