Stream: git-wasmtime

Topic: wasmtime / PR #2310 Cranelift AArch64: Improve code gener...

Wasmtime GitHub notifications bot (Oct 22 2020 at 17:03):

akirilov-arm opened PR #2310 from vector_constants to main:

In particular, introduce initial support for the MOVI and MVNI instructions, with 8-bit elements. Also, treat vector constants as 32- or 64-bit floating-point numbers, if their value allows it, by relying on the architectural zero extension. Finally, stop generating literal loads for 32-bit constants.

cc @julian-seward1

Wasmtime GitHub notifications bot (Oct 28 2020 at 22:33):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Oct 28 2020 at 22:33):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Oct 28 2020 at 22:33):

cfallin created PR Review Comment:

This should be -1, as you noted, to be consistent with #2058; after a bit of digging, this seems to be a simple mistake (on my part) in inst_predicates::is_constant_64bit(), where the bool actually becomes a u64, currently 1 or 0. That should simply be -1 masked down to the appropriate width, I think.

Wasmtime GitHub notifications bot (Oct 30 2020 at 13:16):

akirilov-arm updated PR #2310 from vector_constants to main:

In particular, introduce initial support for the MOVI and MVNI instructions, with 8-bit elements. Also, treat vector constants as 32- or 64-bit floating-point numbers, if their value allows it, by relying on the architectural zero extension. Finally, stop generating literal loads for 32-bit constants.

cc @julian-seward1

Wasmtime GitHub notifications bot (Nov 02 2020 at 05:56):

cfallin merged PR #2310.

Last updated: Oct 23 2024 at 20:03 UTC