Stream: git-wasmtime

Topic: wasmtime / PR #2293 souper-harvest: Do not generate assig...

Wasmtime GitHub notifications bot (Oct 16 2020 at 00:03):

fitzgen opened PR #2293 from souper-no-assign-constant to main:

It turns out that Souper does not allow a constant to be assigned to a variable,
they may only be used as operands. The 2.0.0 version of the souper-ir crate
correctly reflects this. In the cranelift_codegen::souper_harvest module, we
need to modify our Souper IR harvester so that it delays converting iconst and
bconst into Souper IR until their values are used as operands. Finally, some
unit tests in the peepmatic-souper crate need some small updates as well.

@iximeow could you take a look at this? Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 16 2020 at 00:03):

fitzgen requested iximeow for a review on PR #2293.

Wasmtime GitHub notifications bot (Oct 16 2020 at 00:05):

fitzgen updated PR #2293 from souper-no-assign-constant to main:

It turns out that Souper does not allow a constant to be assigned to a variable,
they may only be used as operands. The 2.0.0 version of the souper-ir crate
correctly reflects this. In the cranelift_codegen::souper_harvest module, we
need to modify our Souper IR harvester so that it delays converting iconst and
bconst into Souper IR until their values are used as operands. Finally, some
unit tests in the peepmatic-souper crate need some small updates as well.

@iximeow could you take a look at this? Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 16 2020 at 18:23):

fitzgen updated PR #2293 from souper-no-assign-constant to main:

It turns out that Souper does not allow a constant to be assigned to a variable,
they may only be used as operands. The 2.0.0 version of the souper-ir crate
correctly reflects this. In the cranelift_codegen::souper_harvest module, we
need to modify our Souper IR harvester so that it delays converting iconst and
bconst into Souper IR until their values are used as operands. Finally, some
unit tests in the peepmatic-souper crate need some small updates as well.

@iximeow could you take a look at this? Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 16 2020 at 22:07):

fitzgen updated PR #2293 from souper-no-assign-constant to main:

It turns out that Souper does not allow a constant to be assigned to a variable,
they may only be used as operands. The 2.0.0 version of the souper-ir crate
correctly reflects this. In the cranelift_codegen::souper_harvest module, we
need to modify our Souper IR harvester so that it delays converting iconst and
bconst into Souper IR until their values are used as operands. Finally, some
unit tests in the peepmatic-souper crate need some small updates as well.

@iximeow could you take a look at this? Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 03 2020 at 22:37):

fitzgen requested alexcrichton and iximeow for a review on PR #2293.

Wasmtime GitHub notifications bot (Dec 03 2020 at 22:42):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Dec 03 2020 at 22:43):

fitzgen updated PR #2293 from souper-no-assign-constant to main:

It turns out that Souper does not allow a constant to be assigned to a variable,
they may only be used as operands. The 2.0.0 version of the souper-ir crate
correctly reflects this. In the cranelift_codegen::souper_harvest module, we
need to modify our Souper IR harvester so that it delays converting iconst and
bconst into Souper IR until their values are used as operands. Finally, some
unit tests in the peepmatic-souper crate need some small updates as well.

@iximeow could you take a look at this? Thanks!

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Dec 03 2020 at 23:20):

fitzgen merged PR #2293.

Last updated: Dec 23 2024 at 13:07 UTC