Stream: git-wasmtime

Topic: wasmtime / PR #2287 Some SimpleJIT improvements

Wasmtime GitHub notifications bot (Oct 12 2020 at 09:52):

bjorn3 opened PR #2287 from simplejit_improvements to main:

Follow up to #2249. This re-introduces the finalize_definitions and get_finalized_* methods, but only for SimpleJIT. This also implements Linkage::Preemptible for SimpleJIT.

Wasmtime GitHub notifications bot (Oct 12 2020 at 12:06):

bjorn3 updated PR #2287 from simplejit_improvements to main:

Follow up to #2249. This re-introduces the finalize_definitions and get_finalized_* methods, but only for SimpleJIT. This also implements Linkage::Preemptible for SimpleJIT.

Wasmtime GitHub notifications bot (Oct 12 2020 at 12:09):

bjorn3 updated PR #2287 from simplejit_improvements to main:

Follow up to #2249. This re-introduces the finalize_definitions and get_finalized_* methods, but only for SimpleJIT. This also implements Linkage::Preemptible for SimpleJIT.

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:18):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:18):

pchickey created PR Review Comment:

relocs should be pub for this to be useful to an end user

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:18):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:18):

pchickey created PR Review Comment:

stack_maps should be pub as well

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:23):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:23):

bjorn3 created PR Review Comment:

This type isn't public. It is only used to collect relocations for future usage by simplejit.

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:24):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 27 2020 at 20:24):

bjorn3 created PR Review Comment:

Same here except it doesn't seems to be used at all.

Wasmtime GitHub notifications bot (Oct 29 2020 at 19:09):

pchickey submitted PR Review.

Wasmtime GitHub notifications bot (Oct 29 2020 at 19:09):

pchickey merged PR #2287.

Last updated: Oct 23 2024 at 20:03 UTC