Stream: git-wasmtime

Topic: wasmtime / PR #2276 [debug] Normalise value prior to righ...

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:31):

ggreif opened PR #2276 from main to main:

by first left-aligning (shift left by 32 bits)
then shifting back (respecting signedness)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:31):

ggreif edited PR #2276 from main to main:

by first left-aligning (shift left by 32 bits)
then shifting back (respecting signedness)

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:34):

bjorn3 created PR Review Comment:

                   // Extend with the (arithmetic) shift.

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:34):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:34):

ggreif updated PR #2276 from main to main:

by first left-aligning (shift left by 32 bits)
then shifting back (respecting signedness)

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:39):

ggreif submitted PR Review.

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:39):

ggreif created PR Review Comment:

                    // Extend with the (arithmetic) shift.

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:39):

ggreif updated PR #2276 from main to main:

by first left-aligning (shift left by 32 bits)
then shifting back (respecting signedness)

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:41):

ggreif submitted PR Review.

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:41):

ggreif created PR Review Comment:

                Operation::Shr { .. } | Operation::Shra { .. } => {

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:42):

ggreif updated PR #2276 from main to main:

by first left-aligning (shift left by 32 bits)
then shifting back (respecting signedness)

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 12:55):

ggreif edited PR #2276 from main to main:

Due to the 32-bit WASM/64-bit wasmtime VM schism the DW_OP_shr* operations end up with random bits frobbed from the upper portion of the 64-bit operand word. I plan to submit a fix to the location translator that inserts (something akin to) DW_OP_lit32; DW_OP_shl; DW_OP_lit32; DW_OP_shrX in front of DW_OP_shrX. The rationale is that this will clean out the upper portion, respecting 32-bit signedness.

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 13:07):

ggreif updated PR #2276 from main to main:

Due to the 32-bit WASM/64-bit wasmtime VM schism the DW_OP_shr* operations end up with random bits frobbed from the upper portion of the 64-bit operand word. I plan to submit a fix to the location translator that inserts (something akin to) DW_OP_lit32; DW_OP_shl; DW_OP_lit32; DW_OP_shrX in front of DW_OP_shrX. The rationale is that this will clean out the upper portion, respecting 32-bit signedness.

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 13:23):

ggreif updated PR #2276 from main to main:

Due to the 32-bit WASM/64-bit wasmtime VM schism the DW_OP_shr* operations end up with random bits frobbed from the upper portion of the 64-bit operand word. I plan to submit a fix to the location translator that inserts (something akin to) DW_OP_lit32; DW_OP_shl; DW_OP_lit32; DW_OP_shrX in front of DW_OP_shrX. The rationale is that this will clean out the upper portion, respecting 32-bit signedness.

TODO:

• add translation tests for DW_OP_shr(a)

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 13:26):

ggreif edited PR #2276 from main to main:

Due to the 32-bit WASM/64-bit wasmtime VM schism the DW_OP_shr* operations end up with random bits frobbed from the upper portion of the 64-bit operand word. I plan to submit a fix to the location translator that inserts (something akin to) DW_OP_lit32; DW_OP_shl; DW_OP_lit32; DW_OP_shrX in front of DW_OP_shrX. The rationale is that this will clean out the upper portion, respecting 32-bit signedness.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Oct 07 2020 at 13:32):

ggreif has marked PR #2276 as ready for review.

Wasmtime GitHub notifications bot (Oct 07 2020 at 13:33):

ggreif edited PR #2276 from main to main:

Due to the 32-bit WASM/64-bit wasmtime VM schism the DW_OP_shr* operations end up with random bits frobbed from the upper portion of the 64-bit operand word. This fixes up to the location translator such that it inserts (something akin to) DW_OP_lit32; DW_OP_shl; DW_OP_lit32; DW_OP_shrX in front of DW_OP_shrX. The rationale is that this will clean out the upper portion, respecting 32-bit signedness.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Last updated: Oct 23 2024 at 20:03 UTC