Stream: git-wasmtime

Topic: wasmtime / PR #2275 Remove dead code


view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2020 at 12:29):

bnjbvr opened PR #2275 from remove-dead-code to main:

Building on top of #2258 (2 additional commits), this removes dead code. Also as a bonus, adds the ability to emit NOP instructions of variable sizes, since this had not been done yet; this can be used to e.g. align loop headers on code cache boundaries, which showed a small performance benefits for tight loops in Spidermonkey. I didn't find a marker for blocks that are loop headers in the lowering code, so this is left as an exercise to the reader/@cfallin if he's interested :-)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2020 at 12:29):

bnjbvr requested cfallin for a review on PR #2275.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 07 2020 at 17:33):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2020 at 07:29):

bnjbvr updated PR #2275 from remove-dead-code to main:

Building on top of #2258 (2 additional commits), this removes dead code. Also as a bonus, adds the ability to emit NOP instructions of variable sizes, since this had not been done yet; this can be used to e.g. align loop headers on code cache boundaries, which showed a small performance benefits for tight loops in Spidermonkey. I didn't find a marker for blocks that are loop headers in the lowering code, so this is left as an exercise to the reader/@cfallin if he's interested :-)

view this post on Zulip Wasmtime GitHub notifications bot (Oct 08 2020 at 08:05):

bnjbvr merged PR #2275.


Last updated: Dec 23 2024 at 12:05 UTC