Wasmtime GitHub notifications bot (Oct 06 2020 at 07:45): Wasmtime GitHub notifications bot (Oct 06 2020 at 07:45):subtly opened PR #2270 from main to main:
Add freebsd support to get_pc; this compiles however tests fail. Maybe useful for #2269.
Wasmtime GitHub notifications bot (Oct 06 2020 at 17:28):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Oct 06 2020 at 17:28):alexcrichton created PR Review Comment:
I think this may not be valid syntax, you may want to double-check that this compiles perhaps?
Wasmtime GitHub notifications bot (Oct 06 2020 at 19:24):subtly updated PR #2270 from main to main:
Add freebsd support to get_pc; this compiles however tests fail. Maybe useful for #2269.
Wasmtime GitHub notifications bot (Oct 07 2020 at 00:03):subtly updated PR #2270 from main to main:
Add freebsd support to get_pc; this compiles however tests fail. Maybe useful for #2269.
Wasmtime GitHub notifications bot (Oct 07 2020 at 00:55):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Oct 07 2020 at 00:55):alexcrichton created PR Review Comment:
I think the
#[cfg]expression here is invalid syntax, since that's only valid for thecfg_if!macro which doesn't work in a nested fashion like this. Could this be split like 32/64-bit Linux?
Wasmtime GitHub notifications bot (Oct 07 2020 at 04:36):subtly updated PR #2270 from main to main:
Add freebsd support to get_pc; this compiles however tests fail. Maybe useful for #2269.
Wasmtime GitHub notifications bot (Oct 07 2020 at 07:27):subtly updated PR #2270 from main to main:
Add freebsd support to get_pc; this compiles however tests fail. Maybe useful for #2269.
Wasmtime GitHub notifications bot (Oct 07 2020 at 07:32):subtly submitted PR Review.
Wasmtime GitHub notifications bot (Oct 07 2020 at 07:32):subtly created PR Review Comment:
libc doesn't have ucontext_t for x86, so only x86_64 will work until its ported
Wasmtime GitHub notifications bot (Oct 07 2020 at 11:30):alexcrichton merged PR #2270.
Last updated: Oct 23 2024 at 20:03 UTC