Stream: git-wasmtime

Topic: wasmtime / PR #2266 machinst x64: New backend unwind

Wasmtime GitHub notifications bot (Oct 06 2020 at 17:35):

yurydelendik edited PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [ ] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [ ] some externref / gc tests stopped working, due to stackmaps?

Wasmtime GitHub notifications bot (Oct 06 2020 at 19:56):

yurydelendik edited PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [ ] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>

Wasmtime GitHub notifications bot (Oct 06 2020 at 21:38):

yurydelendik edited PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [ ] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 09 2020 at 19:00):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [ ] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 09 2020 at 20:49):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [ ] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 09 2020 at 21:29):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 09 2020 at 21:29):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 09 2020 at 21:29):

bjorn3 created PR Review Comment:

This trait is public so conditionally adding this without default would break outside implementors of this trait that expect to have unwind disabled when it isn't due to another crate.

Wasmtime GitHub notifications bot (Oct 09 2020 at 21:29):

bjorn3 created PR Review Comment:

Maybe introduce struct InsnRange(InsnIndex, InsnIndex);?

Wasmtime GitHub notifications bot (Oct 09 2020 at 21:29):

bjorn3 created PR Review Comment:

All fields are public, so conditionally adding a field is a breaking change.

Wasmtime GitHub notifications bot (Oct 09 2020 at 21:39):

yurydelendik created PR Review Comment:

I would like to remove "unwind" feature. @bjorn3, as the library user, is unwind info something you are planning to use?

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:14):

yurydelendik edited PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:15):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:18):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [ ] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:19):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:19):

bjorn3 created PR Review Comment:

I use unwind info for .eh_frame generation in cg_clif.

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:25):

yurydelendik created PR Review Comment:

does it make sense to remove #[cfg(feature = "unwind")] at this point?

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:27):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:37):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Oct 09 2020 at 22:37):

bjorn3 created PR Review Comment:

It pulls in gimli and some users may not use unwind info. I don't know if #[cfg(feature = "unwind")] should be kept or removed.

Wasmtime GitHub notifications bot (Oct 14 2020 at 17:44):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 14 2020 at 17:59):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 14 2020 at 19:33):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Oct 14 2020 at 19:33):

yurydelendik created PR Review Comment:

Addressed it in d807af3 by keeping this member mandatory to implement.

Wasmtime GitHub notifications bot (Oct 19 2020 at 21:45):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 20 2020 at 21:49):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [ ] not to use UnwindInfoKind?
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [ ] make unwind info available without feature?

Wasmtime GitHub notifications bot (Oct 20 2020 at 21:50):

yurydelendik edited PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [x] <del>not to use UnwindInfoKind?</del>
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [x] <del>make unwind info available without feature?</del>

Wasmtime GitHub notifications bot (Oct 20 2020 at 21:52):

yurydelendik has marked PR #2266 as ready for review.

Wasmtime GitHub notifications bot (Oct 20 2020 at 21:53):

yurydelendik requested peterhuene for a review on PR #2266.

Wasmtime GitHub notifications bot (Oct 20 2020 at 22:15):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [x] <del>not to use UnwindInfoKind?</del>
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [x] <del>make unwind info available without feature?</del>

Wasmtime GitHub notifications bot (Oct 22 2020 at 03:32):

peterhuene submitted PR Review.

Wasmtime GitHub notifications bot (Oct 23 2020 at 16:54):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [x] <del>not to use UnwindInfoKind?</del>
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [x] <del>make unwind info available without feature?</del>

Wasmtime GitHub notifications bot (Oct 23 2020 at 17:04):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [x] <del>not to use UnwindInfoKind?</del>
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [x] <del>make unwind info available without feature?</del>

Wasmtime GitHub notifications bot (Oct 23 2020 at 17:44):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [x] <del>not to use UnwindInfoKind?</del>
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [x] <del>make unwind info available without feature?</del>

Wasmtime GitHub notifications bot (Oct 23 2020 at 19:42):

yurydelendik updated PR #2266 from new-backend-unwind to main:

Addresses unwind for experimental x64 item from #2079 . Code was just changed copy for the old x86 backend for SystemV. The preliminary code enables backtrace on SystemV call convension; enables "traps::*" tests there.

Investigate or not sure if possible:

• [x] fix unit test in new "systemv.rs"
• [x] detect "sp += " + "group" push
• [x] <del>not to use UnwindInfoKind?</del>
• [x] <del>some externref / gc tests stopped working, due to stackmaps?</del>
• [x] <del>make unwind info available without feature?</del>

Wasmtime GitHub notifications bot (Oct 23 2020 at 20:19):

yurydelendik merged PR #2266.

Last updated: Dec 23 2024 at 12:05 UTC