Stream: git-wasmtime

Topic: wasmtime / PR #2263 Add initial support for the multi-mem...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2020 at 17:16):

alexcrichton opened PR #2263 from multi-memory to main:

This commit adds initial (gated) support for the multi-memory wasm
proposal. This was actually quite easy since almost all of wasmtime
already expected multi-memory to be implemented one day. The only real
substantive change is the memory.copy intrinsic changes, which now
accounts for the source/destination memories possibly being different.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 05 2020 at 17:46):

alexcrichton updated PR #2263 from multi-memory to main:

This commit adds initial (gated) support for the multi-memory wasm
proposal. This was actually quite easy since almost all of wasmtime
already expected multi-memory to be implemented one day. The only real
substantive change is the memory.copy intrinsic changes, which now
accounts for the source/destination memories possibly being different.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2020 at 17:50):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2020 at 17:50):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 13 2020 at 17:50):

fitzgen created PR Review Comment:

This seems like a useful helper to factor out, in general, similar to what we have for getting tables regardless of whether they are defined/imported.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2020 at 00:13):

alexcrichton updated PR #2263 from multi-memory to main:

This commit adds initial (gated) support for the multi-memory wasm
proposal. This was actually quite easy since almost all of wasmtime
already expected multi-memory to be implemented one day. The only real
substantive change is the memory.copy intrinsic changes, which now
accounts for the source/destination memories possibly being different.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2020 at 00:13):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2020 at 00:13):

alexcrichton created PR Review Comment:

Oh wow turns out the helper already exists and I just missed it!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 14 2020 at 00:13):

alexcrichton merged PR #2263.

Last updated: Dec 23 2024 at 12:05 UTC