Wasmtime GitHub notifications bot (Oct 02 2020 at 18:59): Wasmtime GitHub notifications bot (Oct 02 2020 at 18:59):cfallin opened PR #2259 from fix-arm32-build to main:
It turns out that while we don't have the partial/experimental arm32
backend tested on our CI yet, the Firefox build does at least rely on
the backend to build, because it specifies thearm32feature to
cranelift-codegen, even if it will never invoke the backend.
Our previous old-framework arm32 stub at least compiled, so it didn't
break Firefox.We should probably add a CI build check to ensure we don't bitrot what
we have here, but this is the immediate fix to get us back to sanity.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 02 2020 at 18:59):cfallin requested bnjbvr and julian-seward1 for a review on PR #2259.
Wasmtime GitHub notifications bot (Oct 02 2020 at 18:59):cfallin requested bnjbvr and julian-seward1 for a review on PR #2259.
Wasmtime GitHub notifications bot (Oct 02 2020 at 19:19):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Oct 02 2020 at 19:34):cfallin merged PR #2259.
Last updated: Oct 23 2024 at 20:03 UTC