Wasmtime GitHub notifications bot (Sep 26 2020 at 00:56): Wasmtime GitHub notifications bot (Sep 26 2020 at 00:56):joshuawarner32 opened PR #2235 from dont-implicitly-create-empty-files to main:
Prior to this change, non-existent files opened inside the wasi/wasm binary via
std::fs::read_to_string()would show up as existing and empty.Any guidance on where tests should be added would be most helpful.
Not sure who should review?
Wasmtime GitHub notifications bot (Sep 26 2020 at 00:58):joshuawarner32 updated PR #2235 from dont-implicitly-create-empty-files to main:
Prior to this change, non-existent files opened inside the wasi/wasm binary via
std::fs::read_to_string()would show up as existing and empty.Any guidance on where tests should be added would be most helpful.
Not sure who should review?
Wasmtime GitHub notifications bot (Sep 26 2020 at 01:32):joshuawarner32 updated PR #2235 from dont-implicitly-create-empty-files to main:
Prior to this change, non-existent files opened inside the wasi/wasm binary via
std::fs::read_to_string()would show up as existing and empty.Any guidance on where tests should be added would be most helpful.
Not sure who should review?
Wasmtime GitHub notifications bot (Sep 26 2020 at 01:35):joshuawarner32 edited PR #2235 from dont-implicitly-create-empty-files to main:
Prior to this change, non-existent files opened inside the wasi/wasm binary via
std::fs::read_to_string()would show up as existing and empty. Added a test that demonstrates the issue.
Wasmtime GitHub notifications bot (Sep 26 2020 at 01:48):joshuawarner32 updated PR #2235 from dont-implicitly-create-empty-files to main:
Prior to this change, non-existent files opened inside the wasi/wasm binary via
std::fs::read_to_string()would show up as existing and empty. Added a test that demonstrates the issue.
Wasmtime GitHub notifications bot (Sep 26 2020 at 02:51):iximeow submitted PR Review.
Wasmtime GitHub notifications bot (Sep 26 2020 at 02:52):iximeow merged PR #2235.
Last updated: Dec 23 2024 at 12:05 UTC