Wasmtime GitHub notifications bot (Sep 24 2020 at 17:14): Wasmtime GitHub notifications bot (Sep 24 2020 at 17:14):kamyuentse opened PR #2227 from fix/docs/lang-go to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->The golang example is broken, this patch make it work again.
Wasmtime GitHub notifications bot (Sep 24 2020 at 17:20):kamyuentse updated PR #2227 from fix/docs/lang-go to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->The golang example is broken, this patch make it work again.
Wasmtime GitHub notifications bot (Sep 24 2020 at 17:24):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Sep 24 2020 at 17:24):bjorn3 created PR Review Comment:
I think it would make sense to move this just after
engine := wasmtime.NewEngine().
Wasmtime GitHub notifications bot (Sep 24 2020 at 17:28):kamyuentse updated PR #2227 from fix/docs/lang-go to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->The golang example is broken, this patch make it work again.
Wasmtime GitHub notifications bot (Sep 24 2020 at 17:35):kamyuentse submitted PR Review.
Wasmtime GitHub notifications bot (Sep 24 2020 at 17:35):kamyuentse created PR Review Comment:
Although I have moved this line, I can not reason about, can you share your point?
Wasmtime GitHub notifications bot (Sep 24 2020 at 18:26):bjorn3 submitted PR Review.
Wasmtime GitHub notifications bot (Sep 24 2020 at 18:26):bjorn3 created PR Review Comment:
I can't really. It is more of a "it feels better" than "I have a concrete reason it is better".
Wasmtime GitHub notifications bot (Sep 24 2020 at 18:26):bjorn3 edited PR Review Comment.
Wasmtime GitHub notifications bot (Sep 25 2020 at 00:25):alexcrichton merged PR #2227.
Last updated: Dec 23 2024 at 13:07 UTC