Stream: git-wasmtime

Topic: wasmtime / PR #2226 machinst x64: enable CLIF testing

Wasmtime GitHub notifications bot (Sep 24 2020 at 15:41):

bnjbvr opened PR #2226 from x64-clif-testing to main:

This adds a new feature experimental_x64 for CLIF tests.

A test is run in the new x64 backend iff:

• either the test doesn't have an x86_64 target requirement, signaling
  it must be target agnostic or not run on this target.

• or the test does require the x86_64 target, and the test is marked
  with the experimental_x64 feature.

This required one workaround in the parser. The reason is that the
parser will try to use information not provided by the TargetIsa adapter
for the Mach backends, like register names. In particular, parsing test
may fail before the test runner realizes that the test must not be run.
In this case, we early return an almost-empty TestFile from the parser,
under the same conditions as above, so that the caller may filter out
the test properly.

This also copies two tests from the test suite using the new backend,
for demonstration purposes.

Wasmtime GitHub notifications bot (Sep 24 2020 at 19:08):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Sep 24 2020 at 19:08):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Sep 24 2020 at 19:08):

abrown created PR Review Comment:

I would have expected these tests under .../filetests/isa/x64?

Wasmtime GitHub notifications bot (Sep 24 2020 at 19:08):

abrown created PR Review Comment:

And looking at the filetest structure more closely, what do you think about a slight re-organization in a separate PR:

• filetests/vcode/* get moved under filetests/isa
• move a bunch of the optimization directories under a new filetests/opt
  I'm just thinking that finding where to put new tests is getting challenging.

Wasmtime GitHub notifications bot (Sep 24 2020 at 19:08):

abrown edited PR Review Comment.

Wasmtime GitHub notifications bot (Sep 24 2020 at 19:08):

abrown submitted PR Review.

Wasmtime GitHub notifications bot (Sep 25 2020 at 08:24):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Sep 25 2020 at 08:24):

bnjbvr created PR Review Comment:

I've moved them over to isa/x64; for the rest, I'm not sure what you mean by the optimization directories, so we could discuss it somewhere convenient.

Wasmtime GitHub notifications bot (Sep 25 2020 at 08:25):

bnjbvr updated PR #2226 from x64-clif-testing to main:

This adds a new feature experimental_x64 for CLIF tests.

A test is run in the new x64 backend iff:

• either the test doesn't have an x86_64 target requirement, signaling
  it must be target agnostic or not run on this target.

• or the test does require the x86_64 target, and the test is marked
  with the experimental_x64 feature.

This required one workaround in the parser. The reason is that the
parser will try to use information not provided by the TargetIsa adapter
for the Mach backends, like register names. In particular, parsing test
may fail before the test runner realizes that the test must not be run.
In this case, we early return an almost-empty TestFile from the parser,
under the same conditions as above, so that the caller may filter out
the test properly.

This also copies two tests from the test suite using the new backend,
for demonstration purposes.

Wasmtime GitHub notifications bot (Sep 25 2020 at 09:12):

bnjbvr merged PR #2226.

Last updated: Oct 23 2024 at 20:03 UTC