jgouly opened PR #2224 from sp_adjust
to main
:
…llee-saved registers
This also passes
fixed_frame_storage_size
(previouslytotal_sp_adjust
)
intogen_clobber_save
so that it can be combined with other stack
adjustments.Copyright (c) 2020, Arm Limited.
NOTE: I haven't tested this on x86, hopefully CI will be enough.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
Before this patch,
stack_size
was the same the clobbered size, which is the value that must be returned from this function. Now, it's the clobbered size + fixed frame size, so stack management is probably broken because of this (explaining random failures). Instead, only the clobbered size (which could have its own variable) should be returned.
jgouly updated PR #2224 from sp_adjust
to main
:
…llee-saved registers
This also passes
fixed_frame_storage_size
(previouslytotal_sp_adjust
)
intogen_clobber_save
so that it can be combined with other stack
adjustments.Copyright (c) 2020, Arm Limited.
NOTE: I haven't tested this on x86, hopefully CI will be enough.
jgouly created PR Review Comment:
Thanks, I should have realised that.
jgouly submitted PR Review.
cfallin submitted PR Review.
jgouly updated PR #2224 from sp_adjust
to main
:
…llee-saved registers
This also passes
fixed_frame_storage_size
(previouslytotal_sp_adjust
)
intogen_clobber_save
so that it can be combined with other stack
adjustments.Copyright (c) 2020, Arm Limited.
NOTE: I haven't tested this on x86, hopefully CI will be enough.
jgouly updated PR #2224 from sp_adjust
to main
:
…llee-saved registers
This also passes
fixed_frame_storage_size
(previouslytotal_sp_adjust
)
intogen_clobber_save
so that it can be combined with other stack
adjustments.Copyright (c) 2020, Arm Limited.
NOTE: I haven't tested this on x86, hopefully CI will be enough.
jgouly updated PR #2224 from sp_adjust
to main
:
…llee-saved registers
This also passes
fixed_frame_storage_size
(previouslytotal_sp_adjust
)
intogen_clobber_save
so that it can be combined with other stack
adjustments.Copyright (c) 2020, Arm Limited.
NOTE: I haven't tested this on x86, hopefully CI will be enough.
cfallin merged PR #2224.
Last updated: Dec 23 2024 at 13:07 UTC