Stream: git-wasmtime

Topic: wasmtime / PR #2224 arm64: Use SignedOffset rather than P...

Wasmtime GitHub notifications bot (Sep 24 2020 at 10:22):

jgouly opened PR #2224 from sp_adjust to main:

…llee-saved registers

This also passes fixed_frame_storage_size (previously total_sp_adjust)
into gen_clobber_save so that it can be combined with other stack
adjustments.

Copyright (c) 2020, Arm Limited.

NOTE: I haven't tested this on x86, hopefully CI will be enough.

Wasmtime GitHub notifications bot (Sep 24 2020 at 12:28):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Sep 24 2020 at 12:28):

bnjbvr created PR Review Comment:

Before this patch, stack_size was the same the clobbered size, which is the value that must be returned from this function. Now, it's the clobbered size + fixed frame size, so stack management is probably broken because of this (explaining random failures). Instead, only the clobbered size (which could have its own variable) should be returned.

Wasmtime GitHub notifications bot (Sep 24 2020 at 13:58):

jgouly updated PR #2224 from sp_adjust to main:

…llee-saved registers

This also passes fixed_frame_storage_size (previously total_sp_adjust)
into gen_clobber_save so that it can be combined with other stack
adjustments.

Copyright (c) 2020, Arm Limited.

NOTE: I haven't tested this on x86, hopefully CI will be enough.

Wasmtime GitHub notifications bot (Sep 24 2020 at 13:59):

jgouly created PR Review Comment:

Thanks, I should have realised that.

Wasmtime GitHub notifications bot (Sep 24 2020 at 13:59):

jgouly submitted PR Review.

Wasmtime GitHub notifications bot (Sep 29 2020 at 19:42):

cfallin submitted PR Review.

Wasmtime GitHub notifications bot (Sep 30 2020 at 10:56):

jgouly updated PR #2224 from sp_adjust to main:

…llee-saved registers

This also passes fixed_frame_storage_size (previously total_sp_adjust)
into gen_clobber_save so that it can be combined with other stack
adjustments.

Copyright (c) 2020, Arm Limited.

NOTE: I haven't tested this on x86, hopefully CI will be enough.

Wasmtime GitHub notifications bot (Oct 02 2020 at 15:05):

jgouly updated PR #2224 from sp_adjust to main:

…llee-saved registers

This also passes fixed_frame_storage_size (previously total_sp_adjust)
into gen_clobber_save so that it can be combined with other stack
adjustments.

Copyright (c) 2020, Arm Limited.

NOTE: I haven't tested this on x86, hopefully CI will be enough.

Wasmtime GitHub notifications bot (Oct 02 2020 at 15:24):

jgouly updated PR #2224 from sp_adjust to main:

…llee-saved registers

This also passes fixed_frame_storage_size (previously total_sp_adjust)
into gen_clobber_save so that it can be combined with other stack
adjustments.

Copyright (c) 2020, Arm Limited.

NOTE: I haven't tested this on x86, hopefully CI will be enough.

Wasmtime GitHub notifications bot (Oct 02 2020 at 16:18):

cfallin merged PR #2224.

Last updated: Oct 23 2024 at 20:03 UTC