Stream: git-wasmtime

Topic: wasmtime / PR #2216 Finish packed arithmetic implementati...

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2020 at 19:41):

abrown opened PR #2216 from iabs to main:

This completes the implementation of packed arithmetic in the x64 backend and enables the associated spec tests. @bnjbvr, I also disabled simd_const.wast in the final commit since it is now failing (stack_store?); you may have been discussing this in the Cranelift meeting but I was having audio issues early on so I missed parts of that.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2020 at 19:42):

abrown updated PR #2216 from iabs to main:

This completes the implementation of packed arithmetic in the x64 backend and enables the associated spec tests. @bnjbvr, I also disabled simd_const.wast in the final commit since it is now failing (stack_store?); you may have been discussing this in the Cranelift meeting but I was having audio issues early on so I missed parts of that.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 21 2020 at 19:42):

abrown requested bnjbvr for a review on PR #2216.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2020 at 13:55):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2020 at 13:55):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2020 at 13:55):

bnjbvr created PR Review Comment:

Can you add at least one test for every new SSE opcode, please?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2020 at 13:55):

bnjbvr created PR Review Comment:

can you add a panic! or unimplemented in the else case, please? It would be better not to silently lower nothing for an opcode in general.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2020 at 20:24):

abrown updated PR #2216 from iabs to main:

This completes the implementation of packed arithmetic in the x64 backend and enables the associated spec tests. @bnjbvr, I also disabled simd_const.wast in the final commit since it is now failing (stack_store?); you may have been discussing this in the Cranelift meeting but I was having audio issues early on so I missed parts of that.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 23 2020 at 22:40):

abrown merged PR #2216.

Last updated: Nov 22 2024 at 17:03 UTC