Wasmtime GitHub notifications bot (Sep 15 2020 at 23:50): Wasmtime GitHub notifications bot (Sep 15 2020 at 23:50):pchickey opened PR #2205 from pch/wasi_common_sched_methods to main:
based on #2201 and #2202
prior to this, we would report a missing entry for an fd as an error
event, but not a bad capability. why? i think because of the way the
code was written.Also, we'd poll rather than report subscription errors as early as
possible. This is an odd choice because maybe none of the non-errored
subscriptions would ever come due, leaving the user waiting forever
with no error to react to. So, now poll_oneoff returns early if
any of the subscriptions were parsed as an error.The extraction of the
Eventtype and its subordinates from sched
and sys is still incomplete. That representation changes in ephemeral
and working on this refactoring has made me want to make even more
changes to the design of the interface (userdata isnt a good design
imho!) so i'm going to hold off on that for a minute till we come
up with a better consensus on the design there.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 16 2020 at 17:54):pchickey updated PR #2205 from pch/wasi_common_sched_methods to main:
based on #2201 and #2202
prior to this, we would report a missing entry for an fd as an error
event, but not a bad capability. why? i think because of the way the
code was written.Also, we'd poll rather than report subscription errors as early as
possible. This is an odd choice because maybe none of the non-errored
subscriptions would ever come due, leaving the user waiting forever
with no error to react to. So, now poll_oneoff returns early if
any of the subscriptions were parsed as an error.The extraction of the
Eventtype and its subordinates from sched
and sys is still incomplete. That representation changes in ephemeral
and working on this refactoring has made me want to make even more
changes to the design of the interface (userdata isnt a good design
imho!) so i'm going to hold off on that for a minute till we come
up with a better consensus on the design there.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 16 2020 at 18:22):pchickey updated PR #2205 from pch/wasi_common_sched_methods to main:
based on #2201 and #2202
prior to this, we would report a missing entry for an fd as an error
event, but not a bad capability. why? i think because of the way the
code was written.Also, we'd poll rather than report subscription errors as early as
possible. This is an odd choice because maybe none of the non-errored
subscriptions would ever come due, leaving the user waiting forever
with no error to react to. So, now poll_oneoff returns early if
any of the subscriptions were parsed as an error.The extraction of the
Eventtype and its subordinates from sched
and sys is still incomplete. That representation changes in ephemeral
and working on this refactoring has made me want to make even more
changes to the design of the interface (userdata isnt a good design
imho!) so i'm going to hold off on that for a minute till we come
up with a better consensus on the design there.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 01 2020 at 00:34):pchickey updated PR #2205 from pch/wasi_common_sched_methods to main:
based on #2201 and #2202
prior to this, we would report a missing entry for an fd as an error
event, but not a bad capability. why? i think because of the way the
code was written.Also, we'd poll rather than report subscription errors as early as
possible. This is an odd choice because maybe none of the non-errored
subscriptions would ever come due, leaving the user waiting forever
with no error to react to. So, now poll_oneoff returns early if
any of the subscriptions were parsed as an error.The extraction of the
Eventtype and its subordinates from sched
and sys is still incomplete. That representation changes in ephemeral
and working on this refactoring has made me want to make even more
changes to the design of the interface (userdata isnt a good design
imho!) so i'm going to hold off on that for a minute till we come
up with a better consensus on the design there.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Oct 08 2020 at 01:24):pchickey updated PR #2205 from pch/wasi_common_sched_methods to main:
based on #2201 and #2202
prior to this, we would report a missing entry for an fd as an error
event, but not a bad capability. why? i think because of the way the
code was written.Also, we'd poll rather than report subscription errors as early as
possible. This is an odd choice because maybe none of the non-errored
subscriptions would ever come due, leaving the user waiting forever
with no error to react to. So, now poll_oneoff returns early if
any of the subscriptions were parsed as an error.The extraction of the
Eventtype and its subordinates from sched
and sys is still incomplete. That representation changes in ephemeral
and working on this refactoring has made me want to make even more
changes to the design of the interface (userdata isnt a good design
imho!) so i'm going to hold off on that for a minute till we come
up with a better consensus on the design there.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Nov 10 2020 at 19:16):pchickey updated PR #2205 from pch/wasi_common_sched_methods to main:
based on #2201 and #2202
prior to this, we would report a missing entry for an fd as an error
event, but not a bad capability. why? i think because of the way the
code was written.Also, we'd poll rather than report subscription errors as early as
possible. This is an odd choice because maybe none of the non-errored
subscriptions would ever come due, leaving the user waiting forever
with no error to react to. So, now poll_oneoff returns early if
any of the subscriptions were parsed as an error.The extraction of the
Eventtype and its subordinates from sched
and sys is still incomplete. That representation changes in ephemeral
and working on this refactoring has made me want to make even more
changes to the design of the interface (userdata isnt a good design
imho!) so i'm going to hold off on that for a minute till we come
up with a better consensus on the design there.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Dec 02 2020 at 21:23):pchickey closed without merge PR #2205.
Last updated: Nov 22 2024 at 17:03 UTC