Stream: git-wasmtime

Topic: wasmtime / PR #2201 wasi-common: code motion around type ...

Wasmtime GitHub notifications bot (Sep 15 2020 at 00:03):

pchickey opened PR #2201 from pch/wasi_common_move_type_imports to main:

This PR should be NFC (no functional change) - just code motion.

The wiggle transformation of wasi-common saw us import the generated types all over the crate via use crate::wasi::types;. In order to make the crate more agile for future changes to the way we do wiggle codegen for supporting multiple snapshots, this PR sets in place the design pattern that:

• only the handle, fd, and sched modules get to import types from the wiggle codegen
• all other modules import the types they need from those modules
• drop the types:: prefix everywhere we can

We ignore this rule in snapshots::wasi_snapshot_preview1 because we'll be making more changes to that soon.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Sep 15 2020 at 17:03):

pchickey requested iximeow for a review on PR #2201.

Wasmtime GitHub notifications bot (Sep 16 2020 at 21:38):

iximeow submitted PR Review.

Wasmtime GitHub notifications bot (Sep 16 2020 at 21:39):

iximeow submitted PR Review.

Wasmtime GitHub notifications bot (Sep 16 2020 at 21:48):

pchickey merged PR #2201.

Last updated: Dec 23 2024 at 12:05 UTC