Wasmtime GitHub notifications bot (Sep 11 2020 at 11:17): Wasmtime GitHub notifications bot (Sep 11 2020 at 11:17):bnjbvr opened PR #2194 from wasm-multivalue-truncate-after-if to main:
Parameters are duplicated when pushing an If block, so they're available
to the Else block without an extra heap allocation. However, when
truncating the stack after popping the If control frame, the stack size
at entry doesn't account for the duplicated parameters. That is
intentional: the Else block uses this value to know what's the stack
size when it is entered, so there's nothing to change there.This patch makes the wasm translation truncates the value stack to the
right size after an If block, by taking those duplicated parameters into
account.
Wasmtime GitHub notifications bot (Sep 11 2020 at 11:17):bnjbvr requested fitzgen and cfallin for a review on PR #2194.
Wasmtime GitHub notifications bot (Sep 11 2020 at 11:17):bnjbvr requested fitzgen and cfallin for a review on PR #2194.
Wasmtime GitHub notifications bot (Sep 11 2020 at 15:34):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Sep 11 2020 at 15:34):fitzgen merged PR #2194.
Last updated: Dec 23 2024 at 12:05 UTC