wasmtime / PR #2192 Convert Souper optimizations to Peepm... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #2192 Convert Souper optimizations to Peepm...

Wasmtime GitHub notifications bot (Sep 10 2020 at 20:14):

fitzgen opened PR #2192 from souper-to-peepmatic to main:

Conversion from Souper into Peepmatic is implemented with a straightforward, top-down recursive traversal of the optimization's left- and right-hand side expression DAGs. Most Souper instructions have a corresponding Peepmatic instruction. If we run into an instruction where that isn't the case, we skip that Souper optimization and move on to the next one.

Note that Souper fully supports DAGs, for example:
%0 = var
%1 = add 1, %0
%2 = add %1, %1       ;; Two edges to `%1` makes this a DAG.
On the other hand, Peepmatic only currently supports trees, so shared subexpressions are duplicated:
(iadd (iadd 1 $x)
      (iadd 1 $x))    ;; The shared subexpression is duplicated.
This does not, however, affect correctness.

See also #2184, which is related.

Wasmtime GitHub notifications bot (Sep 10 2020 at 20:14):

fitzgen requested alexcrichton for a review on PR #2192.

Wasmtime GitHub notifications bot (Sep 10 2020 at 20:54):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Sep 10 2020 at 20:54):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Sep 10 2020 at 20:54):

bjorn3 created PR Review Comment:

You could use as_bytes()[1] as % is in the ascii range and you are checking if it is an ascii lowercase alphabetic character.

Wasmtime GitHub notifications bot (Sep 10 2020 at 23:06):

fitzgen updated PR #2192 from souper-to-peepmatic to main:

Conversion from Souper into Peepmatic is implemented with a straightforward, top-down recursive traversal of the optimization's left- and right-hand side expression DAGs. Most Souper instructions have a corresponding Peepmatic instruction. If we run into an instruction where that isn't the case, we skip that Souper optimization and move on to the next one.

Note that Souper fully supports DAGs, for example:
%0 = var
%1 = add 1, %0
%2 = add %1, %1       ;; Two edges to `%1` makes this a DAG.
On the other hand, Peepmatic only currently supports trees, so shared subexpressions are duplicated:
(iadd (iadd 1 $x)
      (iadd 1 $x))    ;; The shared subexpression is duplicated.
This does not, however, affect correctness.

See also #2184, which is related.

Wasmtime GitHub notifications bot (Sep 11 2020 at 18:18):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Sep 11 2020 at 21:18):

fitzgen updated PR #2192 from souper-to-peepmatic to main:

Conversion from Souper into Peepmatic is implemented with a straightforward, top-down recursive traversal of the optimization's left- and right-hand side expression DAGs. Most Souper instructions have a corresponding Peepmatic instruction. If we run into an instruction where that isn't the case, we skip that Souper optimization and move on to the next one.

Note that Souper fully supports DAGs, for example:
%0 = var
%1 = add 1, %0
%2 = add %1, %1       ;; Two edges to `%1` makes this a DAG.
On the other hand, Peepmatic only currently supports trees, so shared subexpressions are duplicated:
(iadd (iadd 1 $x)
      (iadd 1 $x))    ;; The shared subexpression is duplicated.
This does not, however, affect correctness.

See also #2184, which is related.

Wasmtime GitHub notifications bot (Sep 11 2020 at 21:21):

fitzgen updated PR #2192 from souper-to-peepmatic to main:

Conversion from Souper into Peepmatic is implemented with a straightforward, top-down recursive traversal of the optimization's left- and right-hand side expression DAGs. Most Souper instructions have a corresponding Peepmatic instruction. If we run into an instruction where that isn't the case, we skip that Souper optimization and move on to the next one.

Note that Souper fully supports DAGs, for example:
%0 = var
%1 = add 1, %0
%2 = add %1, %1       ;; Two edges to `%1` makes this a DAG.
On the other hand, Peepmatic only currently supports trees, so shared subexpressions are duplicated:
(iadd (iadd 1 $x)
      (iadd 1 $x))    ;; The shared subexpression is duplicated.
This does not, however, affect correctness.

See also #2184, which is related.

Wasmtime GitHub notifications bot (Sep 11 2020 at 21:54):

fitzgen merged PR #2192.

Last updated: Nov 22 2024 at 17:03 UTC