Wasmtime GitHub notifications bot (Sep 02 2020 at 12:56): Wasmtime GitHub notifications bot (Sep 02 2020 at 12:56):jgouly opened PR #2181 from madd-opt to main:
Copyright (c) 2020, Arm Limited.
Wasmtime GitHub notifications bot (Sep 02 2020 at 13:44):jgouly updated PR #2181 from madd-opt to main:
Copyright (c) 2020, Arm Limited.
Wasmtime GitHub notifications bot (Sep 03 2020 at 10:11):jgouly updated PR #2181 from madd-opt to main:
Copyright (c) 2020, Arm Limited.
Wasmtime GitHub notifications bot (Sep 08 2020 at 16:20):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Sep 08 2020 at 16:20):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Sep 08 2020 at 16:20):cfallin created PR Review Comment:
@julian-seward1 was going to investigate some weird spilling behavior in the regalloc, and I suspect this may be related. OK to leave this for now, I suppose, since it becomes zero bytes in the output, but hopefully we have a better fix soon!
Wasmtime GitHub notifications bot (Sep 08 2020 at 16:20):cfallin created PR Review Comment:
Can we call this
addend_idx?
Wasmtime GitHub notifications bot (Sep 09 2020 at 04:39):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Sep 09 2020 at 04:39):julian-seward1 created PR Review Comment:
I'd prefer that this NOP was removed before landing. That it has any effect possibly involves some combination of the RA's spill-cost heuristics and/or isel reaching back for operands over basic block boundaries and/or the possibility that isel has separately created an instruction to do the multiply. There's no particular reason it would have this effect in other cases, and I'd prefer not to have to reason about it when trying to debug these RA effects -- things are complicated enough without it.
Wasmtime GitHub notifications bot (Sep 11 2020 at 17:07):jgouly updated PR #2181 from madd-opt to main:
Copyright (c) 2020, Arm Limited.
Wasmtime GitHub notifications bot (Sep 15 2020 at 18:52):cfallin merged PR #2181.
Last updated: Oct 23 2024 at 20:03 UTC