Wasmtime GitHub notifications bot (Sep 02 2020 at 06:44): Wasmtime GitHub notifications bot (Sep 02 2020 at 06:44):jlb6740 opened PR #2180 from simd-negate-x64 to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 02 2020 at 06:44):jlb6740 requested bnjbvr for a review on PR #2180.
Wasmtime GitHub notifications bot (Sep 02 2020 at 06:44):jlb6740 requested cfallin and bnjbvr for a review on PR #2180.
Wasmtime GitHub notifications bot (Sep 02 2020 at 06:45):jlb6740 requested cfallin, abrown and bnjbvr for a review on PR #2180.
Wasmtime GitHub notifications bot (Sep 02 2020 at 06:47):jlb6740 updated PR #2180 from simd-negate-x64 to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 02 2020 at 17:17):jlb6740 updated PR #2180 from simd-negate-x64 to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 07 2020 at 06:56):jlb6740 updated PR #2180 from simd-negate-x64 to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr created PR Review Comment:
uber nit: can you add a \n before this case statement, please? (and after it, too)
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr submitted PR Review.
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr created PR Review Comment:
uber nit: can you add a dot at the end of this sentence, please?
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr created PR Review Comment:
In theory,
inegcan also accept non-vector inputs (I think this is addressed in #2158 even). Thus can you remove thepackedword from this panic message, please?
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr created PR Review Comment:
Can you add a comment that we can't preemptively use
dstas the temporary since it might alias thesrcinput, please?
Wasmtime GitHub notifications bot (Sep 07 2020 at 15:05):bnjbvr created PR Review Comment:
How about naming this
tmp? It is unclear to me what the relation of this temporary tolhsis, and this is really just a temporary value.
Wasmtime GitHub notifications bot (Sep 07 2020 at 17:06):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Sep 07 2020 at 17:06):jlb6740 created PR Review Comment:
Got it. Will try to avoid this in the future.
Wasmtime GitHub notifications bot (Sep 07 2020 at 18:20):jlb6740 updated PR #2180 from simd-negate-x64 to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Sep 07 2020 at 18:21):jlb6740 submitted PR Review.
Wasmtime GitHub notifications bot (Sep 07 2020 at 18:21):jlb6740 created PR Review Comment:
just named it to tmp.
Wasmtime GitHub notifications bot (Sep 07 2020 at 18:56):jlb6740 merged PR #2180.
Last updated: Dec 23 2024 at 13:07 UTC