Stream: git-wasmtime

Topic: wasmtime / PR #2177 machinst aarch64: in baldrdash, allow...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 09:36):

bnjbvr opened PR #2177 from machinst-aarch64-baldrdash-ret-vals to main:

Baldrdash's API requires that there is at most one result in a register,
across all the possible register classes: in particular, it's not
possible to return an i64 value in a register while returning an v128
value in another register.

This patch adds a notion of "remaining register values", so this is
properly taking into account when choosing whether a return value may be
put into a register or not.

cc @cfallin @julian-seward1

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 09:36):

bnjbvr requested lars-t-hansen for a review on PR #2177.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 10:02):

bnjbvr updated PR #2177 from machinst-aarch64-baldrdash-ret-vals to main:

Baldrdash's API requires that there is at most one result in a register,
across all the possible register classes: in particular, it's not
possible to return an i64 value in a register while returning an v128
value in another register.

This patch adds a notion of "remaining register values", so this is
properly taking into account when choosing whether a return value may be
put into a register or not.

cc @cfallin @julian-seward1

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 10:21):

lars-t-hansen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 10:36):

bnjbvr merged PR #2177.


Last updated: Dec 23 2024 at 13:07 UTC