Stream: git-wasmtime

Topic: wasmtime / PR #2176 Fix typo in generated documentation f...

Wasmtime GitHub notifications bot (Aug 30 2020 at 11:41):

CohenArthur opened PR #2176 from typo-entity-documentation to main:

The same function documentation was used for from_u32() and as_u32()
while their behavior is different. The culprit was the generated documentation from
the entity! macro

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 30 2020 at 11:41):

CohenArthur updated PR #2176 from typo-entity-documentation to main:

The same function documentation was used for from_u32() and as_u32()
while their behavior is different. The culprit was the generated documentation from
the entity! macro

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 31 2020 at 08:39):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Aug 31 2020 at 08:39):

bnjbvr submitted PR Review.

Wasmtime GitHub notifications bot (Aug 31 2020 at 08:39):

bnjbvr created PR Review Comment:

            /// Create a new instance from a `u32`.

Wasmtime GitHub notifications bot (Aug 31 2020 at 08:39):

bnjbvr updated PR #2176 from typo-entity-documentation to main:

The same function documentation was used for from_u32() and as_u32()
while their behavior is different. The culprit was the generated documentation from
the entity! macro

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 31 2020 at 08:40):

bnjbvr merged PR #2176.

Last updated: Oct 23 2024 at 20:03 UTC