CohenArthur opened PR #2176 from typo-entity-documentation
to main
:
The same function documentation was used for
from_u32()
andas_u32()
while their behavior is different. The culprit was the generated documentation from
theentity!
macro<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
CohenArthur updated PR #2176 from typo-entity-documentation
to main
:
The same function documentation was used for
from_u32()
andas_u32()
while their behavior is different. The culprit was the generated documentation from
theentity!
macro<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bnjbvr submitted PR Review.
bnjbvr submitted PR Review.
bnjbvr created PR Review Comment:
/// Create a new instance from a `u32`.
bnjbvr updated PR #2176 from typo-entity-documentation
to main
:
The same function documentation was used for
from_u32()
andas_u32()
while their behavior is different. The culprit was the generated documentation from
theentity!
macro<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
bnjbvr merged PR #2176.
Last updated: Dec 23 2024 at 12:05 UTC