Stream: git-wasmtime

Topic: wasmtime / PR #2174 Don't substract 1 from end_addr in li...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2020 at 16:35):

bjorn3 opened PR #2174 from patch-2 to main:

Fixes #2173

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2020 at 22:18):

bjorn3 updated PR #2174 from patch-2 to main:

Fixes #2173

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:04):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:04):

yurydelendik created PR Review Comment:

maybe add a comment similar to what we have in the test?

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:07):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:39):

ggreif submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:44):

ggreif created PR Review Comment:

This is a copy&pasted function which could be refactored. I didn't do it, because this is test-only code. If somebody objects, I'm happy to fix.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:47):

ggreif submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 14:47):

ggreif created PR Review Comment:

nextln: 0x000000000000013d     15      3      1   0             0  end_sequence

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 15:01):

bjorn3 updated PR #2174 from patch-2 to main:

Fixes #2173

view this post on Zulip Wasmtime GitHub notifications bot (Aug 31 2020 at 16:24):

yurydelendik submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 07 2020 at 13:41):

yurydelendik merged PR #2174.

Last updated: Dec 23 2024 at 12:05 UTC