Wasmtime GitHub notifications bot (Aug 27 2020 at 23:04): Wasmtime GitHub notifications bot (Aug 27 2020 at 23:04):pchickey opened PR #2169 from pch/fix_wasmtime_wiggle to main:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 27 2020 at 23:06):pchickey requested aturon for a review on PR #2169.
Wasmtime GitHub notifications bot (Aug 27 2020 at 23:12):pchickey updated PR #2169 from pch/fix_wasmtime_wiggle to main:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 27 2020 at 23:15):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Aug 27 2020 at 23:15):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Aug 28 2020 at 01:20):pchickey updated PR #2169 from pch/fix_wasmtime_wiggle to main:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 28 2020 at 01:23):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Aug 28 2020 at 01:23):peterhuene created PR Review Comment:
Perhaps the shellexpand crate?
Wasmtime GitHub notifications bot (Aug 28 2020 at 22:35):pchickey submitted PR Review.
Wasmtime GitHub notifications bot (Aug 28 2020 at 22:35):pchickey created PR Review Comment:
Great idea, idk why I thought to reinvent this wheel, that looks like a sensible dep.
Wasmtime GitHub notifications bot (Aug 28 2020 at 22:43):pchickey updated PR #2169 from pch/fix_wasmtime_wiggle to main:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 28 2020 at 22:58):pchickey updated PR #2169 from pch/fix_wasmtime_wiggle to main:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 29 2020 at 00:11):pchickey updated PR #2169 from pch/fix_wasmtime_wiggle to main:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 29 2020 at 03:40):peterhuene submitted PR Review.
Wasmtime GitHub notifications bot (Aug 31 2020 at 17:05):pchickey merged PR #2169.
Last updated: Nov 22 2024 at 16:03 UTC