pchickey opened PR #2169 from pch/fix_wasmtime_wiggle
to main
:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig
.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey requested aturon for a review on PR #2169.
pchickey updated PR #2169 from pch/fix_wasmtime_wiggle
to main
:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig
.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
peterhuene submitted PR Review.
peterhuene submitted PR Review.
pchickey updated PR #2169 from pch/fix_wasmtime_wiggle
to main
:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig
.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
peterhuene submitted PR Review.
peterhuene created PR Review Comment:
Perhaps the shellexpand crate?
pchickey submitted PR Review.
pchickey created PR Review Comment:
Great idea, idk why I thought to reinvent this wheel, that looks like a sensible dep.
pchickey updated PR #2169 from pch/fix_wasmtime_wiggle
to main
:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig
.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2169 from pch/fix_wasmtime_wiggle
to main
:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig
.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2169 from pch/fix_wasmtime_wiggle
to main
:
… not WASI_ROOT
the WASI_ROOT was leftover from when this code was part of
wig
.Thank you @aturon for bug report.
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
peterhuene submitted PR Review.
pchickey merged PR #2169.
Last updated: Dec 23 2024 at 13:07 UTC