pchickey opened PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here. I'm trying to break it all out into smaller PRs
#2139
#2140
#2160
- rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey edited PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here. I'm trying to break it all out into smaller PRs
#2139
#2140
#2160
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here. I'm trying to break it all out into smaller PRs
#2139
#2140
#2160
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here. I'm trying to break it all out into smaller PRs
#2139
#2140
#2160
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here. I'm trying to break it all out into smaller PRs
#2139
#2140
#2160
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey edited PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey updated PR #2161 from pch/wasi_common_ephemeral
to main
:
There's lots of code motion to happen here.
- [x] rest of crate should not import from crate::wasi::types - just a few select locations (fd, entry, sched)
- [ ] juicy bodies of wasi_snapshot_preview1 moves out to entry::fd, entry::path, sched...
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
pchickey closed without merge PR #2161.
Last updated: Dec 23 2024 at 12:05 UTC