Stream: git-wasmtime

Topic: wasmtime / PR #2158 x64 small integer fixes

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2020 at 09:05):

bjorn3 opened PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2020 at 09:07):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2020 at 09:33):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2020 at 10:48):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2020 at 14:28):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2020 at 14:36):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 23 2020 at 08:50):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Aug 24 2020 at 09:57):

bnjbvr requested bnjbvr for a review on PR #2158.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2020 at 21:00):

MaxGraey submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2020 at 21:00):

MaxGraey created PR Review Comment:

Is it sign extention from small ints to i64, right? Perhaps I'm missing something, that it should look like this I guess:

                I8 => (((value as i64) << 56) >> 56) as u64,
                I16 => (((value as i64) << 48) >> 48) as u64,
                I32 => (((value as i64) << 32) >> 32) as u64,

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2020 at 21:01):

bjorn3 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2020 at 21:01):

bjorn3 created PR Review Comment:

Indeed. Good catch! Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 01 2020 at 21:02):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 10:10):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 10:10):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 10:10):

bnjbvr created PR Review Comment:

We should reuse the SignExtendRaxRdx instruction, because this new instruction you added and the former have the same semantics: sign-extend the "data" (originally on x86, rax is the "data" (Accumulator, hence A) register up to 32 bits, and when more is required, the rdx contains the rest of the Data (hence D in name)). Maybe rename SignExtendRaxRdx to SignExtendData, and make the size an Option to indicate al->ah? (or use 0 for al->ah sign-extension?) Or we could have a SignExtendOpSize enum that contains all the valid sizes for this instruction?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 10:10):

bnjbvr created PR Review Comment:

nit: I think bitwise not would be more colloquial here

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 10:10):

bnjbvr created PR Review Comment:

nit: can you please add a bit more details in the unreachable message: "unhandled output type for shift/rotates: {}"?

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 10:54):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 11:14):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 11:28):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 11:31):

bjorn3 updated PR #2158 from x64_fixes to main:

I am not sure how to implement sshr and ushr for small integers.

Fixes #2121

view this post on Zulip Wasmtime GitHub notifications bot (Sep 08 2020 at 13:00):

bnjbvr merged PR #2158.

Last updated: Nov 22 2024 at 17:03 UTC