Stream: git-wasmtime

Topic: wasmtime / PR #2156 Revert #2137, the extra (seemingly le...

Wasmtime GitHub notifications bot (Aug 21 2020 at 17:04):

ggreif opened PR #2156 from revert-2137 to main:

This corrects my mistake and adds a comment so that I don't make the same error again.

A possibility to test for this (e.g. by wasm2obj or such) would be awesome.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 21 2020 at 17:07):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 21 2020 at 17:29):

ggreif updated PR #2156 from revert-2137 to main:

This corrects my mistake and adds a comment so that I don't make the same error again.

A possibility to test for this (e.g. by wasm2obj or such) would be awesome.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 21 2020 at 17:30):

ggreif edited PR #2156 from revert-2137 to main:

This corrects my mistake (by reverting #2137) and adds a comment so that I don't make the same error again.

A possibility to test for this (e.g. by wasm2obj or such) would be awesome.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 21 2020 at 18:12):

yurydelendik merged PR #2156.

Last updated: Dec 23 2024 at 13:07 UTC