akirilov-arm opened PR #2155 from simd_conversions
to main
:
This PR completes the AArch64 SIMD implementation, at least with respect to the tests from the Wasm SIMD specification. There are still a couple of unimplemented SIMD code paths in the backend (e.g.
Vsplit
), but they are currently not exercised by any tests, so I am not sure how important they are (for example, they might be one of the IR operations that the backend is never supposed to see). In any case I think we are able to emit all instructions that are necessary, so implementing the missing bits shouldn't require more than simple changes tolower_insn_to_regs()
.
bjorn3 created PR Review Comment:
Can you use
out_ty.is_vector()
instead. This would matchi128
too, which is not a vector type.
bjorn3 submitted PR Review.
bjorn3 edited PR Review Comment.
cfallin submitted PR Review.
cfallin submitted PR Review.
cfallin created PR Review Comment:
+1 to this (and perhaps audit the rest of the lowering code as well).
cfallin submitted PR Review.
akirilov-arm updated PR #2155 from simd_conversions
to main
:
This PR completes the AArch64 SIMD implementation, at least with respect to the tests from the Wasm SIMD specification. There are still a couple of unimplemented SIMD code paths in the backend (e.g.
Vsplit
), but they are currently not exercised by any tests, so I am not sure how important they are (for example, they might be one of the IR operations that the backend is never supposed to see). In any case I think we are able to emit all instructions that are necessary, so implementing the missing bits shouldn't require more than simple changes tolower_insn_to_regs()
.
cfallin merged PR #2155.
Last updated: Dec 23 2024 at 13:07 UTC