Wasmtime GitHub notifications bot (Aug 17 2020 at 22:00): Wasmtime GitHub notifications bot (Aug 17 2020 at 22:00):cfallin opened PR #2134 from fix-abi-extension to main:
When storing an argument to a stack location for consumption by a
callee, or storing a return value to an on-stack return slot for
consumption by the caller, the ABI implementation was properly extending
the value but was then performing a store with only the original width.
This fixes the issue by always performing a 64-bit store of the extended
value.Issue reported by @uweigand (thanks!).
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 17 2020 at 22:00):cfallin requested julian-seward1 for a review on PR #2134.
Wasmtime GitHub notifications bot (Aug 18 2020 at 15:37):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Aug 18 2020 at 15:39):cfallin merged PR #2134.
Last updated: Nov 22 2024 at 16:03 UTC