Wasmtime GitHub notifications bot (Aug 08 2020 at 01:46): Wasmtime GitHub notifications bot (Aug 08 2020 at 01:46):cfallin opened PR #2120 from wasm-unreachable-if-else-params to main:
The Wasm translation handles unreachable code sections
specially, skipping ops until the end of a block and a control-flow
merger at which code becomes reachable again. Unfortunately, while the
ordinary else-op handler properly sets up the value stack for the
else-branch with the parameters to the if/else, the unreachable-case
else-op handler did not. This resulted in a bad translation and CLIF
type error despite valid Wasm.Found via fuzzing by :decoder in
https://bugzilla.mozilla.org/show_bug.cgi?id=1657895.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 08 2020 at 01:46):cfallin requested fitzgen for a review on PR #2120.
Wasmtime GitHub notifications bot (Aug 10 2020 at 15:28):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 10 2020 at 15:36):fitzgen merged PR #2120.
Last updated: Dec 23 2024 at 12:05 UTC