Stream: git-wasmtime

Topic: wasmtime / PR #2119 Making caching support optional in Wa...

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:15):

alexcrichton opened PR #2119 from make-cache-optional to main:

This commit moves all of the caching support that currently lives in
wasmtime-environ into a wasmtime-cache crate and makes it optional. The
goal here is to slim down the wasmtime-environ crate and clearly separate
boundaries where caching is a standalone and optional feature, not intertwined
with other crates.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:20):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:20):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:20):

fitzgen created PR Review Comment:

    /// enabled.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:20):

fitzgen created PR Review Comment:

Make sure to also add

[package.metadata.docs.rs]
all-features = true

to the Cargo.toml so users actually see these docs.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:20):

fitzgen submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:24):

alexcrichton updated PR #2119 from make-cache-optional to main:

This commit moves all of the caching support that currently lives in
wasmtime-environ into a wasmtime-cache crate and makes it optional. The
goal here is to slim down the wasmtime-environ crate and clearly separate
boundaries where caching is a standalone and optional feature, not intertwined
with other crates.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:25):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:25):

alexcrichton created PR Review Comment:

I think I'll probably leave this out for now, but only because the cache feature is on-by-default. I think for now we want to avoid pulling in the lightbeam feature which is susceptible to nightly breakage.

Wasmtime GitHub notifications bot (Aug 07 2020 at 20:09):

alexcrichton updated PR #2119 from make-cache-optional to main:

This commit moves all of the caching support that currently lives in
wasmtime-environ into a wasmtime-cache crate and makes it optional. The
goal here is to slim down the wasmtime-environ crate and clearly separate
boundaries where caching is a standalone and optional feature, not intertwined
with other crates.

Wasmtime GitHub notifications bot (Aug 07 2020 at 20:42):

alexcrichton merged PR #2119.

Last updated: Dec 23 2024 at 13:07 UTC