Wasmtime GitHub notifications bot (Aug 07 2020 at 19:12): Wasmtime GitHub notifications bot (Aug 07 2020 at 19:12):fitzgen opened PR #2118 from enable-ref-types-by-default to main:
Both have spent a bit of time enabled in our fuzzers by default and we haven't run into any issues in a while. The one catch was the potential slowdown due to #1883, but
- I measured and, while it did exist, it was on the order of milliseconds when dealing with a 270K wasm module, and
- I've added a commit that fixes the slowdown (and is otherwise generally a tiny speed up by doing a little manual LICM that the compiler failed to do because of a trait method call).
Wasmtime GitHub notifications bot (Aug 07 2020 at 19:12):fitzgen requested alexcrichton for a review on PR #2118.
Wasmtime GitHub notifications bot (Aug 07 2020 at 19:15):fitzgen updated PR #2118 from enable-ref-types-by-default to main:
Both have spent a bit of time enabled in our fuzzers by default and we haven't run into any issues in a while. The one catch was the potential slowdown due to #1883, but
- I measured and, while it did exist, it was on the order of milliseconds when dealing with a 270K wasm module, and
- I've added a commit that fixes the slowdown (and is otherwise generally a tiny speed up by doing a little manual LICM that the compiler failed to do because of a trait method call).
Wasmtime GitHub notifications bot (Aug 07 2020 at 19:37):fitzgen updated PR #2118 from enable-ref-types-by-default to main:
Both have spent a bit of time enabled in our fuzzers by default and we haven't run into any issues in a while. The one catch was the potential slowdown due to #1883, but
- I measured and, while it did exist, it was on the order of milliseconds when dealing with a 270K wasm module, and
- I've added a commit that fixes the slowdown (and is otherwise generally a tiny speed up by doing a little manual LICM that the compiler failed to do because of a trait method call).
Wasmtime GitHub notifications bot (Aug 07 2020 at 23:57):fitzgen updated PR #2118 from enable-ref-types-by-default to main:
Both have spent a bit of time enabled in our fuzzers by default and we haven't run into any issues in a while. The one catch was the potential slowdown due to #1883, but
- I measured and, while it did exist, it was on the order of milliseconds when dealing with a 270K wasm module, and
- I've added a commit that fixes the slowdown (and is otherwise generally a tiny speed up by doing a little manual LICM that the compiler failed to do because of a trait method call).
Wasmtime GitHub notifications bot (Aug 08 2020 at 00:16):alexcrichton submitted PR Review.
Wasmtime GitHub notifications bot (Aug 08 2020 at 00:41):fitzgen merged PR #2118.
Last updated: Dec 23 2024 at 12:05 UTC