Stream: git-wasmtime

Topic: wasmtime / PR #2117 wasmtime: Extract cranelift/lightbeam...

Wasmtime GitHub notifications bot (Aug 07 2020 at 18:51):

alexcrichton opened PR #2117 from move-compilers-out-of-environ to main:

This commit extracts the two implementations of Compiler into two
separate crates, wasmtime-cranelfit and wasmtime-lightbeam. The
wasmtime-jit crate then depends on these two and instantiates them
appropriately. The goal here is to start reducing the weight of the
wasmtime-environ crate, which currently serves as a common set of
types between all wasmtime-* crates. Long-term I'd like to remove the
dependency on Cranelift from wasmtime-environ, but that's going to
take a lot more work.

In the meantime I figure it's a good way to get started by separating
out the lightbeam/cranelift function compilers from the
wasmtime-environ crate. We can continue to iterate on moving things
out in the future, too.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:10):

yurydelendik created PR Review Comment:

It is possible to move some of this imports into "crates/environ/src/data_structures.rs"?

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:10):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:26):

alexcrichton updated PR #2117 from move-compilers-out-of-environ to main:

This commit extracts the two implementations of Compiler into two
separate crates, wasmtime-cranelfit and wasmtime-lightbeam. The
wasmtime-jit crate then depends on these two and instantiates them
appropriately. The goal here is to start reducing the weight of the
wasmtime-environ crate, which currently serves as a common set of
types between all wasmtime-* crates. Long-term I'd like to remove the
dependency on Cranelift from wasmtime-environ, but that's going to
take a lot more work.

In the meantime I figure it's a good way to get started by separating
out the lightbeam/cranelift function compilers from the
wasmtime-environ crate. We can continue to iterate on moving things
out in the future, too.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:26):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:26):

alexcrichton created PR Review Comment:

:+1:

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:27):

alexcrichton updated PR #2117 from move-compilers-out-of-environ to main:

This commit extracts the two implementations of Compiler into two
separate crates, wasmtime-cranelfit and wasmtime-lightbeam. The
wasmtime-jit crate then depends on these two and instantiates them
appropriately. The goal here is to start reducing the weight of the
wasmtime-environ crate, which currently serves as a common set of
types between all wasmtime-* crates. Long-term I'd like to remove the
dependency on Cranelift from wasmtime-environ, but that's going to
take a lot more work.

In the meantime I figure it's a good way to get started by separating
out the lightbeam/cranelift function compilers from the
wasmtime-environ crate. We can continue to iterate on moving things
out in the future, too.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:30):

alexcrichton updated PR #2117 from move-compilers-out-of-environ to main:

This commit extracts the two implementations of Compiler into two
separate crates, wasmtime-cranelfit and wasmtime-lightbeam. The
wasmtime-jit crate then depends on these two and instantiates them
appropriately. The goal here is to start reducing the weight of the
wasmtime-environ crate, which currently serves as a common set of
types between all wasmtime-* crates. Long-term I'd like to remove the
dependency on Cranelift from wasmtime-environ, but that's going to
take a lot more work.

In the meantime I figure it's a good way to get started by separating
out the lightbeam/cranelift function compilers from the
wasmtime-environ crate. We can continue to iterate on moving things
out in the future, too.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:33):

yurydelendik created PR Review Comment:

Nice. Sorry, I also meant other no use cranelift_codegen::XXX above -- they can be re-exported in wasmtime_environ too thus removing direct dependency on cranelift crates.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:33):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:33):

yurydelendik edited PR Review Comment.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:47):

alexcrichton submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 19:47):

alexcrichton created PR Review Comment:

I was thinking of doing that yeah but I realized that lightbeam itself depends on cranelift-codegen, so I figured it was probably best to just do the same thing.

Wasmtime GitHub notifications bot (Aug 07 2020 at 20:10):

alexcrichton updated PR #2117 from move-compilers-out-of-environ to main:

This commit extracts the two implementations of Compiler into two
separate crates, wasmtime-cranelfit and wasmtime-lightbeam. The
wasmtime-jit crate then depends on these two and instantiates them
appropriately. The goal here is to start reducing the weight of the
wasmtime-environ crate, which currently serves as a common set of
types between all wasmtime-* crates. Long-term I'd like to remove the
dependency on Cranelift from wasmtime-environ, but that's going to
take a lot more work.

In the meantime I figure it's a good way to get started by separating
out the lightbeam/cranelift function compilers from the
wasmtime-environ crate. We can continue to iterate on moving things
out in the future, too.

Wasmtime GitHub notifications bot (Aug 07 2020 at 20:43):

alexcrichton updated PR #2117 from move-compilers-out-of-environ to main:

This commit extracts the two implementations of Compiler into two
separate crates, wasmtime-cranelfit and wasmtime-lightbeam. The
wasmtime-jit crate then depends on these two and instantiates them
appropriately. The goal here is to start reducing the weight of the
wasmtime-environ crate, which currently serves as a common set of
types between all wasmtime-* crates. Long-term I'd like to remove the
dependency on Cranelift from wasmtime-environ, but that's going to
take a lot more work.

In the meantime I figure it's a good way to get started by separating
out the lightbeam/cranelift function compilers from the
wasmtime-environ crate. We can continue to iterate on moving things
out in the future, too.

Wasmtime GitHub notifications bot (Aug 19 2020 at 22:44):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 20 2020 at 09:34):

tschneidereit merged PR #2117.

Last updated: Dec 23 2024 at 12:05 UTC