Stream: git-wasmtime

Topic: wasmtime / PR #2113 Don't GC DW_TAG_variant(_part), they ...

Wasmtime GitHub notifications bot (Aug 07 2020 at 11:04):

ggreif opened PR #2113 from dont-gc to main:

This goes analogously to #2107.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 11:05):

ggreif closed without merge PR #2113.

Wasmtime GitHub notifications bot (Aug 07 2020 at 11:05):

ggreif updated PR #2113 from dont-gc to main:

This goes analogously to #2107.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 11:07):

ggreif updated PR #2113 from dont-gc to main:

This goes analogously to #2107.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 11:07):

ggreif reopened PR #2113 from dont-gc to main:

This goes analogously to #2107.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 11:10):

ggreif edited PR #2113 from dont-gc to main:

This goes analogously to #2107.

• DW_TAG_variant is referenced by parent DW_TAG_variant_part
• DW_TAG_variant_part is referenced by parent DW_TAG_structure_type

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 17:57):

ggreif edited PR #2113 from dont-gc to main:

This goes analogously to #2107.

• DW_TAG_variant is referenced by parent DW_TAG_variant_part
• DW_TAG_variant_part is referenced by parent DW_TAG_structure_type

Here is a random example from the debug build directory:

0x00000635:       DW_TAG_structure_type
                    DW_AT_name ("Option<usize>")
                    DW_AT_byte_size    (0x10)
                    DW_AT_alignment    (8)

0x0000063c:         DW_TAG_variant_part
                      DW_AT_discr      (0x00000641)

0x00000641:           DW_TAG_member
                        DW_AT_type     (0x000006c7 "u64")
                        DW_AT_alignment        (8)
                        DW_AT_data_member_location     (DW_OP_plus_uconst 0x0)
                        DW_AT_artificial       (0x01)

0x0000064b:           DW_TAG_variant
                        DW_AT_discr_value      (0x00)

0x0000064d:             DW_TAG_member
                          DW_AT_name   ("None")
                          DW_AT_type   (0x0000066c "None")
                          DW_AT_alignment      (8)
                          DW_AT_data_member_location   (DW_OP_plus_uconst 0x0)

0x0000065a:             NULL

0x0000065b:           DW_TAG_variant
                        DW_AT_discr_value      (0x01)

0x0000065d:             DW_TAG_member
                          DW_AT_name   ("Some")
                          DW_AT_type   (0x0000067d "Some")
                          DW_AT_alignment      (8)
                          DW_AT_data_member_location   (DW_OP_plus_uconst 0x0)

0x0000066a:             NULL

0x0000066b:           NULL

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 17:58):

ggreif edited PR #2113 from dont-gc to main:

This goes analogously to #2107.

• DW_TAG_variant is referenced by parent DW_TAG_variant_part
• DW_TAG_variant_part is referenced by parent DW_TAG_structure_type

Here is a random example from the debug build directory (of wasmtime itself):

0x00000635:       DW_TAG_structure_type
                    DW_AT_name ("Option<usize>")
                    DW_AT_byte_size    (0x10)
                    DW_AT_alignment    (8)

0x0000063c:         DW_TAG_variant_part
                      DW_AT_discr      (0x00000641)

0x00000641:           DW_TAG_member
                        DW_AT_type     (0x000006c7 "u64")
                        DW_AT_alignment        (8)
                        DW_AT_data_member_location     (DW_OP_plus_uconst 0x0)
                        DW_AT_artificial       (0x01)

0x0000064b:           DW_TAG_variant
                        DW_AT_discr_value      (0x00)

0x0000064d:             DW_TAG_member
                          DW_AT_name   ("None")
                          DW_AT_type   (0x0000066c "None")
                          DW_AT_alignment      (8)
                          DW_AT_data_member_location   (DW_OP_plus_uconst 0x0)

0x0000065a:             NULL

0x0000065b:           DW_TAG_variant
                        DW_AT_discr_value      (0x01)

0x0000065d:             DW_TAG_member
                          DW_AT_name   ("Some")
                          DW_AT_type   (0x0000067d "Some")
                          DW_AT_alignment      (8)
                          DW_AT_data_member_location   (DW_OP_plus_uconst 0x0)

0x0000066a:             NULL

0x0000066b:           NULL

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

• [ ] This has been discussed in issue #..., or if not, please tell us why
  here.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

• [ ] This PR contains test cases, if meaningful.

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so. The list of
  suggested reviewers on the right can help you.

Please ensure all communication adheres to the code of conduct.
-->

Wasmtime GitHub notifications bot (Aug 07 2020 at 18:23):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 07 2020 at 18:23):

yurydelendik merged PR #2113.

Last updated: Nov 22 2024 at 17:03 UTC