Wasmtime GitHub notifications bot (Aug 06 2020 at 12:06): Wasmtime GitHub notifications bot (Aug 06 2020 at 12:06):ggreif opened PR #2104 from main to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:09):ggreif updated PR #2104 from main to main:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:12):ggreif edited PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli-rs.
Since` is not contained ingimli-rs` yet, we take care of manually translating it.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:12):ggreif edited PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
Since` is not contained ingimli` yet, we take care of manually translating it.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:13):ggreif edited PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
Since` is not contained ingimli` yet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:14):ggreif submitted PR Review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:14):ggreif created PR Review Comment:
use
gimli::here? And revert line 603?
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:14):ggreif edited PR Review Comment.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:16):ggreif submitted PR Review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:16):ggreif created PR Review Comment:
Allow
DW_OP_WASM_location 0x0 20and other multi-arg opcodes?
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:23):ggreif updated PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
Since` is not contained ingimli` yet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:43):ggreif edited PR Review Comment.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:44):ggreif edited PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
SinceDW_OP_WASM_locationis not contained ingimliyet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.
Wasmtime GitHub notifications bot (Aug 06 2020 at 12:45):ggreif edited PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
SinceDW_OP_WASM_locationis not contained ingimliyet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
Wasmtime GitHub notifications bot (Aug 06 2020 at 14:51):ggreif updated PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
SinceDW_OP_WASM_locationis not contained ingimliyet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:22):yurydelendik submitted PR Review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:22):yurydelendik created PR Review Comment:
yes
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:27):yurydelendik submitted PR Review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:27):yurydelendik created PR Review Comment:
Maybe. But I would limit first arg too (e.g. similar to https://yurydelendik.github.io/webassembly-dwarf/#DWARF-expressions-and-location-descriptions):
DW_OP_WASM_location local ..orDW_OP_WASM_location 0x1 ..
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:32):ggreif updated PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
SinceDW_OP_WASM_locationis not contained ingimliyet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:33):ggreif submitted PR Review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:33):ggreif created PR Review Comment:
Done.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:35):ggreif submitted PR Review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:35):ggreif created PR Review Comment:
I guess we should get fancy in a follow-up. This is testing code, anyway. (But it was useful to learn a macro technique.)
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:35):ggreif has marked PR #2104 as ready for review.
Wasmtime GitHub notifications bot (Aug 06 2020 at 19:35):ggreif requested yurydelendik for a review on PR #2104.
Wasmtime GitHub notifications bot (Aug 07 2020 at 07:28):ggreif updated PR #2104 from main to main:
Provide automatic translation to opcodes from
DW_OP_*identifiers. They are looked up fromgimli.
SinceDW_OP_WASM_locationis not contained ingimliyet, we take care of manually translating it.Since the
let e =definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
Wasmtime GitHub notifications bot (Aug 07 2020 at 18:24):yurydelendik submitted PR Review.
Wasmtime GitHub notifications bot (Aug 07 2020 at 18:25):yurydelendik merged PR #2104.
Last updated: Oct 23 2024 at 20:03 UTC