ggreif opened PR #2104 from main
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
ggreif updated PR #2104 from main
to main
:
<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
ggreif edited PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli-rs
.
Since` is not contained in
gimli-rs` yet, we take care of manually translating it.
ggreif edited PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
Since` is not contained in
gimli` yet, we take care of manually translating it.
ggreif edited PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
Since` is not contained in
gimli` yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.
ggreif submitted PR Review.
ggreif created PR Review Comment:
use
gimli::
here? And revert line 603?
ggreif edited PR Review Comment.
ggreif submitted PR Review.
ggreif created PR Review Comment:
Allow
DW_OP_WASM_location 0x0 20
and other multi-arg opcodes?
ggreif updated PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
Since` is not contained in
gimli` yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.
ggreif edited PR Review Comment.
ggreif edited PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
SinceDW_OP_WASM_location
is not contained ingimli
yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.
ggreif edited PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
SinceDW_OP_WASM_location
is not contained ingimli
yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
ggreif updated PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
SinceDW_OP_WASM_location
is not contained ingimli
yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
yurydelendik submitted PR Review.
yurydelendik created PR Review Comment:
yes
yurydelendik submitted PR Review.
yurydelendik created PR Review Comment:
Maybe. But I would limit first arg too (e.g. similar to https://yurydelendik.github.io/webassembly-dwarf/#DWARF-expressions-and-location-descriptions):
DW_OP_WASM_location local ..
orDW_OP_WASM_location 0x1 ..
ggreif updated PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
SinceDW_OP_WASM_location
is not contained ingimli
yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
ggreif submitted PR Review.
ggreif created PR Review Comment:
Done.
ggreif submitted PR Review.
ggreif created PR Review Comment:
I guess we should get fancy in a follow-up. This is testing code, anyway. (But it was useful to learn a macro technique.)
ggreif has marked PR #2104 as ready for review.
ggreif requested yurydelendik for a review on PR #2104.
ggreif updated PR #2104 from main
to main
:
Provide automatic translation to opcodes from
DW_OP_*
identifiers. They are looked up fromgimli
.
SinceDW_OP_WASM_location
is not contained ingimli
yet, we take care of manually translating it.Since the
let e =
definitions now contain the same information as the separate comments previously, we can zap the comments now.The macros could be improved to handle multi-argument opcodes.
yurydelendik submitted PR Review.
yurydelendik merged PR #2104.
Last updated: Dec 23 2024 at 13:07 UTC