Stream: git-wasmtime

Topic: wasmtime / PR #2097 Fix Wasm translator to handle loop pa...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 23:50):

cfallin opened PR #2097 from fix-wasm-brtable to main:

Similar to an earlier issue for ordinary branches (fixed in PR #1833),
the cranelift-wasm crate did not previously correctly translate a
br_table instruction's default-target branch when the branch target was
a loop with loop parameters. The mistranslated CLIF resulted in a
validation error. This one-line fix simply fills in the correct
parameter count, generating a jump instruction with the appropriate
parameters from the stack.

This issue was found by :decoder in the SpiderMonkey embedding of
Cranelift, in https://bugzilla.mozilla.org/show_bug.cgi?id=1657062. The
test case is from that bug report.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 23:50):

cfallin requested julian-seward1 for a review on PR #2097.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2020 at 00:18):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2020 at 00:20):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2020 at 06:37):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2020 at 17:27):

cfallin merged PR #2097.


Last updated: Dec 23 2024 at 12:05 UTC