Wasmtime GitHub notifications bot (Aug 04 2020 at 23:50): Wasmtime GitHub notifications bot (Aug 04 2020 at 23:50):cfallin opened PR #2097 from fix-wasm-brtable to main:
Similar to an earlier issue for ordinary branches (fixed in PR #1833),
the cranelift-wasm crate did not previously correctly translate a
br_tableinstruction's default-target branch when the branch target was
a loop with loop parameters. The mistranslated CLIF resulted in a
validation error. This one-line fix simply fills in the correct
parameter count, generating a jump instruction with the appropriate
parameters from the stack.This issue was found by :decoder in the SpiderMonkey embedding of
Cranelift, in https://bugzilla.mozilla.org/show_bug.cgi?id=1657062. The
test case is from that bug report.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 04 2020 at 23:50):cfallin requested julian-seward1 for a review on PR #2097.
Wasmtime GitHub notifications bot (Aug 05 2020 at 00:18):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 05 2020 at 00:20):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 05 2020 at 06:37):julian-seward1 submitted PR Review.
Wasmtime GitHub notifications bot (Aug 05 2020 at 17:27):cfallin merged PR #2097.
Last updated: Oct 23 2024 at 20:03 UTC