Wasmtime GitHub notifications bot (Aug 04 2020 at 18:17): Wasmtime GitHub notifications bot (Aug 04 2020 at 18:17):abrown opened PR #2092 from fp-comparisons to main:
I'm open to re-factoring this into the scalar implementation somehow (or any other recommendations, honestly, since it seems a bit verbose) but I kept the vector and scalar implementations separate initially for clarity.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 04 2020 at 18:17):abrown requested cfallin for a review on PR #2092.
Wasmtime GitHub notifications bot (Aug 04 2020 at 18:17):abrown requested jlb6740 for a review on PR #2092.
Wasmtime GitHub notifications bot (Aug 04 2020 at 18:17):abrown requested cfallin and jlb6740 for a review on PR #2092.
Wasmtime GitHub notifications bot (Aug 04 2020 at 18:51):abrown updated PR #2092 from fp-comparisons to main:
I'm open to re-factoring this into the scalar implementation somehow (or any other recommendations, honestly, since it seems a bit verbose) but I kept the vector and scalar implementations separate initially for clarity.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 04 2020 at 18:56):abrown updated PR #2092 from fp-comparisons to main:
I'm open to re-factoring this into the scalar implementation somehow (or any other recommendations, honestly, since it seems a bit verbose) but I kept the vector and scalar implementations separate initially for clarity.
<!--Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 04 2020 at 19:20):abrown has marked PR #2092 as ready for review.
Wasmtime GitHub notifications bot (Aug 04 2020 at 19:22):cfallin submitted PR Review.
Wasmtime GitHub notifications bot (Aug 04 2020 at 20:24):abrown merged PR #2092.
Last updated: Dec 23 2024 at 12:05 UTC