Stream: git-wasmtime

Topic: wasmtime / PR #2091 Remove the `local` field of `Module`


view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 16:18):

alexcrichton opened PR #2091 from remove-module-local to main:

This was added long ago at this point to assist with caching, but
caching has moved to a different level such that this wonky second level
of a Module isn't necessary. This commit removes the ModuleLocal
type to simplify accessors and generally make it easier to work with.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 16:36):

fitzgen submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 16:41):

alexcrichton updated PR #2091 from remove-module-local to main:

This was added long ago at this point to assist with caching, but
caching has moved to a different level such that this wonky second level
of a Module isn't necessary. This commit removes the ModuleLocal
type to simplify accessors and generally make it easier to work with.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 16:49):

alexcrichton updated PR #2091 from remove-module-local to main:

This was added long ago at this point to assist with caching, but
caching has moved to a different level such that this wonky second level
of a Module isn't necessary. This commit removes the ModuleLocal
type to simplify accessors and generally make it easier to work with.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 17:29):

alexcrichton merged PR #2091.


Last updated: Dec 23 2024 at 12:05 UTC