Stream: git-wasmtime

Topic: wasmtime / PR #2088 machinst x64: refactor to use types::...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2020 at 23:10):

abrown opened PR #2088 from refactor-types to main:

This change is a pure refactoring--no change to functionality. It removes use crate::ir::types::* imports and uses instead types::I32, e.g., throughout the x64 code. Though it increases code verbosity, this change makes it more clear where the type identifiers come from (they are generated by cranelif-codegen-meta so without a prefix it is difficult to find their origin), avoids IDE confusion (e.g. CLion flags the un-prefixed identifiers as errors), and avoids importing unwanted identifiers into the namespace.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2020 at 23:14):

abrown requested cfallin for a review on PR #2088.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 03 2020 at 23:47):

cfallin submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 16:26):

abrown updated PR #2088 from refactor-types to main:

This change is a pure refactoring--no change to functionality. It removes use crate::ir::types::* imports and uses instead types::I32, e.g., throughout the x64 code. Though it increases code verbosity, this change makes it more clear where the type identifiers come from (they are generated by cranelif-codegen-meta so without a prefix it is difficult to find their origin), avoids IDE confusion (e.g. CLion flags the un-prefixed identifiers as errors), and avoids importing unwanted identifiers into the namespace.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 04 2020 at 18:53):

abrown requested julian-seward1 for a review on PR #2088.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2020 at 17:03):

abrown updated PR #2088 from refactor-types to main:

This change is a pure refactoring--no change to functionality. It removes use crate::ir::types::* imports and uses instead types::I32, e.g., throughout the x64 code. Though it increases code verbosity, this change makes it more clear where the type identifiers come from (they are generated by cranelif-codegen-meta so without a prefix it is difficult to find their origin), avoids IDE confusion (e.g. CLion flags the un-prefixed identifiers as errors), and avoids importing unwanted identifiers into the namespace.

<!--

Please ensure that the following steps are all taken care of before submitting
the PR.

Please ensure all communication adheres to the code of conduct.
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 05 2020 at 17:45):

abrown merged PR #2088.


Last updated: Dec 23 2024 at 13:07 UTC