Wasmtime GitHub notifications bot (Aug 03 2020 at 17:24): Wasmtime GitHub notifications bot (Aug 03 2020 at 17:24):abrown opened PR #2087 from clif-util-ansi-color to main:
clif-util wasm ...has functionality to print extra information in color when verbose mode (-v) is specified. Previously, the ANSI color escape sequences were printed regardless of whether-vwas used so that users that captured output of this command would have to remove escape sequences from their capture files. With this change,clif-util wasm ...will only print the ANSI color escape sequences when-vis used.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 03 2020 at 17:24):abrown requested fitzgen for a review on PR #2087.
Wasmtime GitHub notifications bot (Aug 03 2020 at 17:48):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 03 2020 at 17:48):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 03 2020 at 17:57):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 03 2020 at 18:47):abrown updated PR #2087 from clif-util-ansi-color to main:
clif-util wasm ...has functionality to print extra information in color when verbose mode (-v) is specified. Previously, the ANSI color escape sequences were printed regardless of whether-vwas used so that users that captured output of this command would have to remove escape sequences from their capture files. With this change,clif-util wasm ...will only print the ANSI color escape sequences when-vis used.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 03 2020 at 19:32):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 03 2020 at 19:32):fitzgen created PR Review Comment:
I just checked with
gitand their options arealways|never|auto. I think it is worth being consistent with that, since people are more likely used to their options than something we make up ourselves. sorry for getting it wrong initially!
Wasmtime GitHub notifications bot (Aug 03 2020 at 19:32):fitzgen submitted PR Review.
Wasmtime GitHub notifications bot (Aug 03 2020 at 20:39):abrown updated PR #2087 from clif-util-ansi-color to main:
clif-util wasm ...has functionality to print extra information in color when verbose mode (-v) is specified. Previously, the ANSI color escape sequences were printed regardless of whether-vwas used so that users that captured output of this command would have to remove escape sequences from their capture files. With this change,clif-util wasm ...will only print the ANSI color escape sequences when-vis used.<!--
Please ensure that the following steps are all taken care of before submitting
the PR.
[ ] This has been discussed in issue #..., or if not, please tell us why
here.[ ] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.[ ] This PR contains test cases, if meaningful.
- [ ] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.Please ensure all communication adheres to the code of conduct.
-->
Wasmtime GitHub notifications bot (Aug 03 2020 at 21:14):abrown merged PR #2087.
Last updated: Nov 22 2024 at 16:03 UTC