Stream: git-wasmtime

Topic: wasmtime / PR #2085 Don't re-parse wasm for debuginfo

Wasmtime GitHub notifications bot (Jul 31 2020 at 17:59):

alexcrichton opened PR #2085 from refactor-debuginfo to main:

This commit updates debuginfo parsing to happen during the main
translation of the original wasm module. This avoid re-parsing the wasm
module twice (at least the section-level headers). Additionally this
ties debuginfo directly to a ModuleTranslation which makes it easier
to process debuginfo for nested modules in the upcoming module linking
proposal.

The changes here are summarized by taking the read_debuginfo function
and merging it with the main module translation that happens which is
driven by cranelift. Some new hooks were added to the module environment
trait to support this, but most of it was integrating with existing hooks.

Wasmtime GitHub notifications bot (Jul 31 2020 at 17:59):

alexcrichton requested yurydelendik for a review on PR #2085.

Wasmtime GitHub notifications bot (Jul 31 2020 at 19:15):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jul 31 2020 at 19:15):

bjorn3 submitted PR Review.

Wasmtime GitHub notifications bot (Jul 31 2020 at 19:15):

bjorn3 created PR Review Comment:

*starts

Wasmtime GitHub notifications bot (Jul 31 2020 at 19:24):

alexcrichton updated PR #2085 from refactor-debuginfo to main:

This commit updates debuginfo parsing to happen during the main
translation of the original wasm module. This avoid re-parsing the wasm
module twice (at least the section-level headers). Additionally this
ties debuginfo directly to a ModuleTranslation which makes it easier
to process debuginfo for nested modules in the upcoming module linking
proposal.

The changes here are summarized by taking the read_debuginfo function
and merging it with the main module translation that happens which is
driven by cranelift. Some new hooks were added to the module environment
trait to support this, but most of it was integrating with existing hooks.

Wasmtime GitHub notifications bot (Aug 03 2020 at 14:09):

yurydelendik submitted PR Review.

Wasmtime GitHub notifications bot (Aug 03 2020 at 14:59):

alexcrichton merged PR #2085.

Last updated: Dec 23 2024 at 12:05 UTC