Stream: git-wasmtime

Topic: wasmtime / PR #2080 machinst x64: add testing to the CI

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:13):

bnjbvr opened PR #2080 from x64-testing to main:

This adds testing for x64; i don't know yet if i got the github CI incantation correctly or not. I've also deferred to later the decisions of what to do with filetests, since it'd be better to have some tests running in CI already (all the non-simd spec tests are passing here too).

Big thanks to @alexcrichton for helping me with Cargo and testing on Zulip!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:13):

bnjbvr requested alexcrichton for a review on PR #2080.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:18):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:18):

alexcrichton submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:18):

alexcrichton created PR Review Comment:

Duplicate steps: definition here

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:18):

alexcrichton created PR Review Comment:

Could this include something about "new backend" in case anyone gets confused that we're only testing x64 in one place?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:18):

alexcrichton created PR Review Comment:

This mentions 1079 but should it be 2079?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 16:18):

alexcrichton created PR Review Comment:

These should be safe to remove since they're covered by testing elsewhere.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 29 2020 at 17:25):

bnjbvr updated PR #2080 from x64-testing to main:

This adds testing for x64; i don't know yet if i got the github CI incantation correctly or not. I've also deferred to later the decisions of what to do with filetests, since it'd be better to have some tests running in CI already (all the non-simd spec tests are passing here too).

Big thanks to @alexcrichton for helping me with Cargo and testing on Zulip!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2020 at 08:31):

bnjbvr submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2020 at 08:31):

bnjbvr created PR Review Comment:

Good catch, thanks

view this post on Zulip Wasmtime GitHub notifications bot (Jul 30 2020 at 08:32):

bnjbvr merged PR #2080.

Last updated: Nov 22 2024 at 17:03 UTC