Stream: git-wasmtime

Topic: wasmtime / PR #2074 machinst x64: use a sign-extension wh...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 09:13):

bnjbvr requested julian-seward1 for a review on PR #2074.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 09:13):

bnjbvr opened PR #2074 from x64-fix-jmp-table-negative to main:

The jump table offset that's loaded out of the jump table could be
signed (if it's an offset to before the jump table itself), so we should
use a signed extension there, not an unsigned extension.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 09:32):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 09:32):

julian-seward1 submitted PR Review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 09:32):

julian-seward1 created PR Review Comment:

nano-nit: It's definitely signed; maybe you meant "it might be negative" ?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 09:52):

bnjbvr updated PR #2074 from x64-fix-jmp-table-negative to main:

The jump table offset that's loaded out of the jump table could be
signed (if it's an offset to before the jump table itself), so we should
use a signed extension there, not an unsigned extension.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 28 2020 at 10:29):

bnjbvr merged PR #2074.

Last updated: Oct 23 2024 at 20:03 UTC