wasmtime / PR #2050 Integrate wasi-nn · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #2050 Integrate wasi-nn

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:28):

abrown opened PR #2050 from wasi-nn to main:

This has the very beginnings of wasi-nn support integrated into Wasmtime. I marked this as a draft because I need help working through some of the generation issues:

on @pchickey's suggestion, I am trying to only bring in the wasi_ephemeral_nn.witx with no external dependencies

after pulling in the repository containing wasi_ephemeral_nn.witx in 97d03e1 (this is likely not the right way to do things--just a temporary hack), I attempt to use the wasmtime_wiggle::wasmtime_integration! and wiggle::from_witx! in c18d421 to create the necessary structures

I get errors but it is unclear to me what is causing them:
wasmtime/crates/wasi-common$ cargo build
   Compiling wasi-common v0.19.1 (wasmtime/crates/wasi-common)
error[E0106]: missing lifetime specifier
 --> crates/wasi-common/src/wasi.rs:6:1
  |
6 | / wiggle::from_witx!({
7 | |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 | |     ctx: WasiCtx,
9 | | });
  | |___^
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider using the named lifetime
  |
6 | wiggle::from_witx!({
7 |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 |     ctx: WasiCtx,
9 | });<'a>
  |

error[E0392]: parameter `'a` is never used
 --> crates/wasi-common/src/wasi.rs:6:1
  |
6 | / wiggle::from_witx!({
7 | |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 | |     ctx: WasiCtx,
9 | | });
  | |___^ unused parameter
  |
  = help: consider removing `'a`, referring to it in a field, or using a marker such as `std::marker::PhantomData`
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0106, E0392.
For more information about an error, try `rustc --explain E0106`.
error: could not compile `wasi-common`.

To learn more, run the command again with --verbose.
I can attach the macro-expanded wasi.rs output if that would help but I'm not too sure where to start here.

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:30):

abrown requested alexcrichton for a review on PR #2050.

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:30):

abrown requested alexcrichton and kubkon for a review on PR #2050.

Wasmtime GitHub notifications bot (Jul 20 2020 at 19:30):

abrown requested alexcrichton, kubkon and sunfishcode for a review on PR #2050.

Wasmtime GitHub notifications bot (Aug 05 2020 at 17:28):

abrown updated PR #2050 from wasi-nn to main:

This has the very beginnings of wasi-nn support integrated into Wasmtime. I marked this as a draft because I need help working through some of the generation issues:

on @pchickey's suggestion, I am trying to only bring in the wasi_ephemeral_nn.witx with no external dependencies
after pulling in the repository containing wasi_ephemeral_nn.witx in 97d03e1 (this is likely not the right way to do things--just a temporary hack), I attempt to use the wasmtime_wiggle::wasmtime_integration! and wiggle::from_witx! in c18d421 to create the necessary structures
I get errors but it is unclear to me what is causing them:

wasmtime/crates/wasi-common$ cargo build
   Compiling wasi-common v0.19.1 (wasmtime/crates/wasi-common)
error[E0106]: missing lifetime specifier
 --> crates/wasi-common/src/wasi.rs:6:1
  |
6 | / wiggle::from_witx!({
7 | |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 | |     ctx: WasiCtx,
9 | | });
  | |___^
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider using the named lifetime
  |
6 | wiggle::from_witx!({
7 |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 |     ctx: WasiCtx,
9 | });<'a>
  |

error[E0392]: parameter `'a` is never used
 --> crates/wasi-common/src/wasi.rs:6:1
  |
6 | / wiggle::from_witx!({
7 | |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 | |     ctx: WasiCtx,
9 | | });
  | |___^ unused parameter
  |
  = help: consider removing `'a`, referring to it in a field, or using a marker such as `std::marker::PhantomData`
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0106, E0392.
For more information about an error, try `rustc --explain E0106`.
error: could not compile `wasi-common`.

To learn more, run the command again with --verbose.

I can attach the macro-expanded wasi.rs output if that would help but I'm not too sure where to start here.

Wasmtime GitHub notifications bot (Aug 05 2020 at 18:01):

abrown updated PR #2050 from wasi-nn to main:

This has the very beginnings of wasi-nn support integrated into Wasmtime. I marked this as a draft because I need help working through some of the generation issues:

on @pchickey's suggestion, I am trying to only bring in the wasi_ephemeral_nn.witx with no external dependencies
after pulling in the repository containing wasi_ephemeral_nn.witx in 97d03e1 (this is likely not the right way to do things--just a temporary hack), I attempt to use the wasmtime_wiggle::wasmtime_integration! and wiggle::from_witx! in c18d421 to create the necessary structures
I get errors but it is unclear to me what is causing them:

wasmtime/crates/wasi-common$ cargo build
   Compiling wasi-common v0.19.1 (wasmtime/crates/wasi-common)
error[E0106]: missing lifetime specifier
 --> crates/wasi-common/src/wasi.rs:6:1
  |
6 | / wiggle::from_witx!({
7 | |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 | |     ctx: WasiCtx,
9 | | });
  | |___^
  |
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider using the named lifetime
  |
6 | wiggle::from_witx!({
7 |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 |     ctx: WasiCtx,
9 | });<'a>
  |

error[E0392]: parameter `'a` is never used
 --> crates/wasi-common/src/wasi.rs:6:1
  |
6 | / wiggle::from_witx!({
7 | |     witx: ["WASI/phases/snapshot/witx/wasi_snapshot_preview1.witx", "WASI/phases/ephemeral/witx/wasi_ephemeral_nn.witx"],
8 | |     ctx: WasiCtx,
9 | | });
  | |___^ unused parameter
  |
  = help: consider removing `'a`, referring to it in a field, or using a marker such as `std::marker::PhantomData`
  = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 2 previous errors

Some errors have detailed explanations: E0106, E0392.
For more information about an error, try `rustc --explain E0106`.
error: could not compile `wasi-common`.

To learn more, run the command again with --verbose.

I can attach the macro-expanded wasi.rs output if that would help but I'm not too sure where to start here.

Wasmtime GitHub notifications bot (Aug 07 2020 at 21:37):

abrown closed without merge PR #2050.

Last updated: Oct 23 2024 at 20:03 UTC